Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cluster setting to use persisted insights #110813

Closed
maryliag opened this issue Sep 18, 2023 · 0 comments · Fixed by #110828
Closed

cluster setting to use persisted insights #110813

maryliag opened this issue Sep 18, 2023 · 0 comments · Fixed by #110828
Assignees
@maryliag
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) O-premortem Issues identified during premortem exercise.

Comments

@maryliag
Copy link
Contributor

maryliag commented Sep 18, 2023 •
edited by cockroach-jira-scripts
Loading

Create a cluster setting that defines if the new persisted insights table can be used when retrieving data from the endpoint calls.

Jira issue: CRDB-31630
@maryliag maryliag added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-cluster-observability O-premortem Issues identified during premortem exercise. labels Sep 18, 2023
@maryliag maryliag self-assigned this Sep 18, 2023
@maryliag maryliag mentioned this issue Sep 18, 2023
Merged
craig bot pushed a commit that referenced this issue Sep 19, 2023
@maryliag @itsbilal
Merge #110828 #110869
9bdb876 
110828: server: create cluster setting for persisted insights r=maryliag a=maryliag

A new table for persisted Insights will be created, and the endpoints to retrive Insights information will be able to use it. This commit creates a cluster settings that can be used to disabled its usage, in case there is a problem with its content.

Fixes #110813

Release note: None

110869: go.mod: bump Pebble to 57e248f9c4d8 r=RaduBerinde a=itsbilal

```
57e248f9 open: Ratchet nextFileNum ahead of objprovider objects
75bc026c db: add invariant for ValueAndErr
61f84632 metamorphic: 0 suffix should be suffixless in the RandomSeparator
be158640 manifest: remove invalid comment
```

Release note: None.

Epic: none

Co-authored-by: maryliag <[email protected]>
Co-authored-by: Bilal Akhtar <[email protected]>
@craig craig bot closed this as completed in d6143c1 Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maryliag maryliag

Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) O-premortem Issues identified during premortem exercise.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

server: create cluster setting for persisted insights maryliag/cockroach
1 participant
@maryliag