ci: fix R <4.2 compatibility and test more R versions #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are the two most recent R versions on the latest Metworx AMI (24.04).
The CI jobs for R 4.0 and 4.1 now fail due to a GGally installation failure triggered by the latest ggstats requiring R 4.2. Trying to resolve that with a targeted pin (like is currently done for evaluate), reveals more issues (broom.helpers requires at least R 4.2, emmeans and survey require at least R 4.1). Rather than chase these targeted pins, just pin RSPM to a known good state (date of the last successful CI run) for R versions before 4.2. And since we're using a date-pinned URL, drop the targeted pin for evaluate and choose a snapshot that has evaluate v0.23. Re: #104
kyleam
changed the title
kylebaron
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the R <4.2 CI failures encountered by gh-104. It also add jobs for R 4.2 and 4.3.
To resolve the CI failures, I originally wanted to do a more targeted pin of ggstats. But, as mentioned in the commit message, there are several other failures to deal with, so I ended up going with the blunter approach of using a date-pinned RSPM.