Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix R <4.2 compatibility and test more R versions #105

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Conversation

kyleam
Copy link
Contributor

@kyleam kyleam commented Oct 2, 2024

This resolves the R <4.2 CI failures encountered by gh-104. It also add jobs for R 4.2 and 4.3.

To resolve the CI failures, I originally wanted to do a more targeted pin of ggstats. But, as mentioned in the commit message, there are several other failures to deal with, so I ended up going with the blunter approach of using a date-pinned RSPM.

These are the two most recent R versions on the latest Metworx AMI
(24.04).
The CI jobs for R 4.0 and 4.1 now fail due to a GGally installation
failure triggered by the latest ggstats requiring R 4.2.  Trying to
resolve that with a targeted pin (like is currently done for
evaluate), reveals more issues (broom.helpers requires at least R 4.2,
emmeans and survey require at least R 4.1).

Rather than chase these targeted pins, just pin RSPM to a known good
state (date of the last successful CI run) for R versions before 4.2.

And since we're using a date-pinned URL, drop the targeted pin for
evaluate and choose a snapshot that has evaluate v0.23.

Re: #104
@kyleam kyleam changed the title ci: fix R <4.2 compatibility and add more R jobs ci: fix R <4.2 compatibility and test more R versions Oct 2, 2024
@kyleam kyleam requested a review from kylebaron October 2, 2024 19:49
@kyleam kyleam merged commit 4c43b30 into main Oct 2, 2024
7 checks passed
@kyleam kyleam deleted the ci-r-compat branch October 2, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants