Refactor eta_covariate to accept integer data #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyleam
added a commit
that referenced
this pull request
Oct 2, 2024
The CI jobs for R 4.0 and 4.1 now fail due to a GGally installation failure triggered by the latest ggstats requiring R 4.2. Trying to resolve that with a targeted pin (like is currently done for evaluate), reveals more issues (broom.helpers requires at least R 4.2, emmeans and survey require at least R 4.1). Rather than chase these targeted pins, just pin RSPM to a known good state (date of the last successful CI run) for R versions before 4.2. And since we're using a date-pinned URL, drop the targeted pin for evaluate and choose a snapshot that has evaluate v0.23. Re: #104
kylebaron
commented
Oct 3, 2024
| @@ -10,7 +10,7 @@ diagnostic_display_list <- function(df, x, y, fun_cat, fun_cont) { | |||
| out[[i]] <- lapply(seq_along(x), function(ii) { | |||
| col <- col_label(x[[ii]])[[1]] | |||
| require_column(df, col) | |||
| if(inherits(unlist(df[, col]), c("character", "factor", "logical", "integer"))) { | |||
| if(.is_discrete(df[[col]])) { | |||
There was a problem hiding this comment.
Moved this decision into a helper function to unify across the package.
kylebaron
commented
Oct 3, 2024
| .is_continuous <- function(x) { | ||
| inherits(x, c("integer", "numeric")) | ||
| } | ||
|
|
There was a problem hiding this comment.
I don't know why this code was so convoluted before.
Making me pull out the dictionary. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #103
The primary finding was an error that is generated when you pass integer x data into
eta_covariate(); that function dispatches tocont_cat()which will generate an error, asking forfactor,characterorlogical. So that dispatch is fixed.This PR also re-factors how discrete and continuous data are detected in checks across the package. This ensures consistent adjudication in different places, specifically the handling when calling
eta_covariate().