Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data for gradient between vertical levels #55

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

mspelman07
Copy link
Contributor

@mspelman07 mspelman07 commented Sep 12, 2024

PR: metoppv/improver#2030

Acceptance test data for gradient between vertical levels

Input Cubes:
Untitled

kgo:
Untitled

Copy link
Contributor

@MoseleyS MoseleyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please strip the StaGE history attributes from these cubes to conform with the IMPROVER metadata standard.

The 850hPa temperature data has an "air_temperature status_flag" aux coord. I believe this is to indicate grid points where the 850hPa level falls below the model orography, so the temperature data are inferred from other data. This doesn't impact your test, but perhaps we need to think about whether these flags should be handled rather than ignored.

@mspelman07
Copy link
Contributor Author

I've removed all the flags from the data and updated the checksums in the improver PR.

Copy link

@mo-robertneal mo-robertneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have plotted the data and looked at the cube coordinates. All looks good to me.

@MoseleyS MoseleyS merged commit 11e2371 into master Oct 14, 2024
@MoseleyS MoseleyS deleted the gradient_between_vertical_levels branch October 14, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants