-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gradient between vertical levels #2030
Gradient between vertical levels #2030
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2030 +/- ##
==========================================
- Coverage 98.39% 98.36% -0.03%
==========================================
Files 124 133 +9
Lines 12212 12878 +666
==========================================
+ Hits 12016 12668 +652
- Misses 196 210 +14 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good PR. I've thought of one way one of the cases could be made more efficient, but I am not sure whether this would actually benefit any of the use cases yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a good solution. Just one blank space needed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks fine to me.
* refs/heads/master: Failing CI (metoppv#2040) Gradient between vertical levels (metoppv#2030) Categorical fix for Deterministic data (metoppv#2038) # Conflicts: # improver_tests/acceptance/SHA256SUMS
EPP:
Acceptance test: metoppv/improver_test_data#55
This plugin adds in the ability to calculate a gradient between two vertical levels which could be defined on pressure or height levels.
Testing: