Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradient between vertical levels #2030

Merged
merged 12 commits into from
Oct 14, 2024

Conversation

mspelman07
Copy link
Contributor

EPP:
Acceptance test: metoppv/improver_test_data#55

This plugin adds in the ability to calculate a gradient between two vertical levels which could be defined on pressure or height levels.

Testing:

  • Ran tests and they passed OK
  • Added new tests for the new feature(s)

@mspelman07 mspelman07 added the EPP PR's related to Enhancing Post Processing team label Sep 12, 2024
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.36%. Comparing base (84a8944) to head (61ed569).
Report is 30 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2030      +/-   ##
==========================================
- Coverage   98.39%   98.36%   -0.03%     
==========================================
  Files         124      133       +9     
  Lines       12212    12878     +666     
==========================================
+ Hits        12016    12668     +652     
- Misses        196      210      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@MoseleyS MoseleyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good PR. I've thought of one way one of the cases could be made more efficient, but I am not sure whether this would actually benefit any of the use cases yet.

improver/utilities/gradient_between_vertical_levels.py Outdated Show resolved Hide resolved
improver/cli/gradient_between_vertical_levels.py Outdated Show resolved Hide resolved
Copy link
Contributor

@MoseleyS MoseleyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good solution. Just one blank space needed!

improver/utilities/gradient_between_vertical_levels.py Outdated Show resolved Hide resolved
MoseleyS
MoseleyS previously approved these changes Oct 4, 2024
improver/utilities/gradient_between_vertical_levels.py Outdated Show resolved Hide resolved
Copy link

@mo-robertneal mo-robertneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks fine to me.

@MoseleyS MoseleyS merged commit 88655a8 into metoppv:master Oct 14, 2024
10 checks passed
MoseleyS added a commit to MoseleyS/improver that referenced this pull request Oct 14, 2024
* refs/heads/master:
  Failing CI (metoppv#2040)
  Gradient between vertical levels (metoppv#2030)
  Categorical fix for Deterministic data (metoppv#2038)

# Conflicts:
#	improver_tests/acceptance/SHA256SUMS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EPP PR's related to Enhancing Post Processing team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants