Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move statsmodels in environment yml files #1556

Merged
merged 3 commits into from
Sep 22, 2021

Conversation

gavinevans
Copy link
Contributor

@gavinevans gavinevans commented Sep 21, 2021

Testing of environment related to #1555

Description
This PR is intended to test the cause of unit test failures in #1555 that are unrelated to the contents of that PR.

Testing:

  • Ran tests and they passed OK
  • Added new tests for the new feature(s)

@gavinevans gavinevans added this to the 1.0.0 milestone Sep 21, 2021
@gavinevans gavinevans self-assigned this Sep 21, 2021
@codecov
Copy link

codecov bot commented Sep 21, 2021

Codecov Report

Merging #1556 (1ffe90c) into master (52c9a34) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1556   +/-   ##
=======================================
  Coverage   97.93%   97.93%           
=======================================
  Files         106      106           
  Lines        9463     9463           
=======================================
  Hits         9268     9268           
  Misses        195      195           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52c9a34...1ffe90c. Read the comment docs.

@gavinevans gavinevans marked this pull request as ready for review September 22, 2021 13:07
Copy link
Contributor

@neilCrosswaite neilCrosswaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@gavinevans gavinevans merged commit f8e2ce4 into metoppv:master Sep 22, 2021
@gavinevans gavinevans deleted the improver1537_move_statsmodels branch September 22, 2021 14:02
MoseleyS added a commit to MoseleyS/improver that referenced this pull request Sep 23, 2021
* master:
  Adds land-mask option to threshold CLI (metoppv#1559)
  Move statsmodels in environment yml files (metoppv#1556)
  rearranged args (metoppv#1558)
  Update Code-Style-Guide.rst (metoppv#1554)
  Updating timezone cli call (metoppv#1551)
MoseleyS added a commit to MoseleyS/improver that referenced this pull request Oct 5, 2021
* bayliffe/mobt77:
  Review changes. Acceptance test added.
  Add type-hinting throughout.
  Formatting.
  Adding unit tests.
  Grouping solution and rename.
  First draft of a modal symbol plugin.
  Modifies LightningFromCapePrecip plugin to accept 3h precipitation-rate-max data (metoppv#1568)
  Moves position of land-sea-mask in threshold CLI (metoppv#1565)
  Re-label a diagnostic as a period diagnostic (metoppv#1561)
  Adds LatitudeThreshold plugin and lightning-filter CLI (metoppv#1550)
  Adds land-mask option to threshold CLI (metoppv#1559)
  Move statsmodels in environment yml files (metoppv#1556)
  rearranged args (metoppv#1558)
  Update Code-Style-Guide.rst (metoppv#1554)
  Updating timezone cli call (metoppv#1551)
MoseleyS pushed a commit to MoseleyS/improver that referenced this pull request Aug 22, 2024
* Move statsmodels in environment yml files.

* Try pinning cartopy to 0.19.

* Update setup.cfg.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants