Updating timezone cli call #1551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1551 +/- ##
=======================================
Coverage 97.93% 97.93%
=======================================
Files 106 106
Lines 9463 9463
=======================================
Hits 9268 9268
Misses 195 195 Continue to review full report at Codecov.
|
tjtg
added
the
BoM review required
tjtg
previously approved these changes
Sep 20, 2021
added 2 commits
September 20, 2021 07:22
|
This has become a bit of a hacky fix, to make this more robust in the future we should consider altering the interface as per #1553 |
|
No acceptance tests for this CLI in master, although we should consider it. |
benfitzpatrick
approved these changes
Sep 21, 2021
MoseleyS
added a commit
to MoseleyS/improver
that referenced
this pull request
Sep 23, 2021
* master: Adds land-mask option to threshold CLI (metoppv#1559) Move statsmodels in environment yml files (metoppv#1556) rearranged args (metoppv#1558) Update Code-Style-Guide.rst (metoppv#1554) Updating timezone cli call (metoppv#1551)
MoseleyS
added a commit
to MoseleyS/improver
that referenced
this pull request
Oct 5, 2021
* bayliffe/mobt77: Review changes. Acceptance test added. Add type-hinting throughout. Formatting. Adding unit tests. Grouping solution and rename. First draft of a modal symbol plugin. Modifies LightningFromCapePrecip plugin to accept 3h precipitation-rate-max data (metoppv#1568) Moves position of land-sea-mask in threshold CLI (metoppv#1565) Re-label a diagnostic as a period diagnostic (metoppv#1561) Adds LatitudeThreshold plugin and lightning-filter CLI (metoppv#1550) Adds land-mask option to threshold CLI (metoppv#1559) Move statsmodels in environment yml files (metoppv#1556) rearranged args (metoppv#1558) Update Code-Style-Guide.rst (metoppv#1554) Updating timezone cli call (metoppv#1551)
MoseleyS
pushed a commit
to MoseleyS/improver
that referenced
this pull request
Aug 22, 2024
* Updated CLI call to match other CLIs * moved time to start and ancil to end * moved documentation * Moved ancil arg into *args to avoid kwarg requirement * tuple friendly * tidied docstring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CLIs for improver generally have the ancil files loaded as the last file. This updates the CLI to match the others within the suite.
Testing: