Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move processor implementation #39

Merged
merged 11 commits into from
Sep 27, 2023
Merged

Move processor implementation #39

merged 11 commits into from
Sep 27, 2023

Conversation

febo
Copy link
Contributor

@febo febo commented Sep 26, 2023

This PR moves the processor implementation from lib.rs to individual instruction files under processor.

@febo febo marked this pull request as ready for review September 27, 2023 17:56
@febo febo requested a review from danenbm September 27, 2023 18:03
danenbm
danenbm requested changes Sep 27, 2023
View reviewed changes
programs/bubblegum/program/src/asserts.rs Outdated Show resolved Hide resolved
programs/bubblegum/program/src/asserts.rs Outdated Show resolved Hide resolved
programs/bubblegum/program/src/asserts.rs Outdated Show resolved Hide resolved
programs/bubblegum/program/src/asserts.rs Outdated Show resolved Hide resolved
danenbm
danenbm previously approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@danenbm danenbm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you for splitting this up!

@febo
Change instruction name (#40)
cab7a38 
* Change instruction name

* Update instruction name enum

* Update generated code

* Add helpers
danenbm
danenbm previously approved these changes Sep 27, 2023
View reviewed changes
@febo febo requested a review from danenbm September 27, 2023 20:57
@febo febo merged commit ecd1146 into main Sep 27, 2023
9 checks passed
@febo febo deleted the febo/rename branch September 27, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danenbm danenbm danenbm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@febo @danenbm