Change instruction name #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danenbm
approved these changes
Sep 27, 2023
Comment on lines
+51
to
+53
| [82, 104, 152, 6, 149, 111, 100, 13] => InstructionName::SetDecompressibleState, | ||
| // `SetDecompressableState` instruction mapped to `SetDecompressibleState` instruction | ||
| [18, 135, 238, 168, 246, 195, 61, 115] => InstructionName::SetDecompressibleState, |
There was a problem hiding this comment.
Just thinking it through: Perhaps technically one could argue if you got the old discriminator you would be interested in the exact instruction name that was called. But I think this is fine because the instructions do the exact same thing. If for example the Read API is parsing the old or the new instruction, any args and account updates it would see would be exact same.
There was a problem hiding this comment.
Yeah, from a binary perspective, all bytes after the discriminator are exactly the same. And the code is exactly the same, only the function name has changed.
febo
added a commit
that referenced
this pull request
Sep 27, 2023
* Move processor implementation * Fix truncated comment * Update generated clients * Fix test compilation * Tweak processor methods visibility * Remove duplicated functions * Change instruction name (#40) * Change instruction name * Update instruction name enum * Update generated code * Add helpers * Update generated clients * Update test import * Update generated clients --------- Co-authored-by: febo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a typo on the
set_decompressible_stateinstruction name. The "old"set_decompressable_stateinstruction is still present on the program for backwards compatibility, but the clients only have the new one.