Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MetadataArgs to UpdateMetadata payload #29

Merged
merged 1 commit into from
Oct 15, 2023

Conversation

danenbm
Copy link
Contributor

@danenbm danenbm commented Oct 10, 2023

MetadataArgs needed for parsing Bubblegum Update Metadata in digital-asset-rpc-infrastructure repo.

@danenbm danenbm force-pushed the danenbm/add-to-update-metadata branch from 3973095 to f5f7a3d Compare October 12, 2023 21:49
@@ -231,7 +248,7 @@ fn build_creator_verification_payload(

// See Bubblegum for offsets and positions:
// https://github.com/metaplex-foundation/mpl-bubblegum/blob/main/programs/bubblegum/README.md#-verify_collection-unverify_collection-and-set_and_verify_collection
// NOTE: Unverfication does not include collection. This needs to be fixed in the README.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I fixed this in the README in a different PR a while back.

@danenbm danenbm marked this pull request as ready for review October 12, 2023 21:52
Copy link

@febo febo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danenbm danenbm merged commit 5b62a73 into update-metadata-staging Oct 15, 2023
@danenbm danenbm deleted the danenbm/add-to-update-metadata branch October 15, 2023 00:17
@danenbm danenbm restored the danenbm/add-to-update-metadata branch October 15, 2023 00:50
danenbm added a commit that referenced this pull request Jan 29, 2024
* Parse `UpdateArgs` from `UpdateMetadata` instruction (#28)

* Run CI on all PRs

* Use Bubblegum Rust SDK

* Update to newer Bubblegum

* Parse UpdateArgs and add to Payload

* Minor changes from PR comments

* Update spl-noop

* Update Cargo lock file

* Update mpl-bubblegum

* Add MetadataArgs to UpdateMetadata payload (#29)

* chore: Release blockbuster version 0.9.0-beta.1

* Danenbm/fix update metadata parse (#30)

* Fix parsing UpdateMetadataInstructionArgs

* Use specific SPL token version

* chore: Release blockbuster version 0.9.0-beta.2

* Allow range for SPL token

* chore: Release blockbuster version 0.9.0-beta.3

* Parse out authority and tree ID for mint_v1 and update_metadata payloads (#31)

* Add metadata to creator verification payload (#32)

* Add metadata to creator verification payload

* Set SPL token to specific version

* chore: Release blockbuster version 0.9.0-beta.4

* Update to latest bubblegum beta

* chore: Release blockbuster version 0.9.0-beta.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants