-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse UpdateArgs
from UpdateMetadata
instruction
#28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danenbm
changed the title
Use Bubblegum Rust SDK
Parse Oct 5, 2023
UpdateArgs
from UpdateMetadata
instruction
febo
reviewed
Oct 5, 2023
febo
reviewed
Oct 5, 2023
febo
reviewed
Oct 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good – there are only two minor comments.
febo
approved these changes
Oct 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
danenbm
added a commit
that referenced
this pull request
Jan 29, 2024
* Parse `UpdateArgs` from `UpdateMetadata` instruction (#28) * Run CI on all PRs * Use Bubblegum Rust SDK * Update to newer Bubblegum * Parse UpdateArgs and add to Payload * Minor changes from PR comments * Update spl-noop * Update Cargo lock file * Update mpl-bubblegum * Add MetadataArgs to UpdateMetadata payload (#29) * chore: Release blockbuster version 0.9.0-beta.1 * Danenbm/fix update metadata parse (#30) * Fix parsing UpdateMetadataInstructionArgs * Use specific SPL token version * chore: Release blockbuster version 0.9.0-beta.2 * Allow range for SPL token * chore: Release blockbuster version 0.9.0-beta.3 * Parse out authority and tree ID for mint_v1 and update_metadata payloads (#31) * Add metadata to creator verification payload (#32) * Add metadata to creator verification payload * Set SPL token to specific version * chore: Release blockbuster version 0.9.0-beta.4 * Update to latest bubblegum beta * chore: Release blockbuster version 0.9.0-beta.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
UpdateArgs
fromUpdateMetadata
instruction and add toPayload
.