Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Use CAPI's ClusterCacheTracker #1911

Merged

Conversation

kashifest
Copy link
Member

This PR intends to use CAPI's ClusterCacheTracker kubernetes-sigs/cluster-api#8744. However, since CAPM3 didn't use CAPI's remote NewClusterClient previously, this has to be done in two steps. Once this PR merges we can remove CAPM3's infra remote code and use CAPI's ClusterCacheTracker consistently.

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 18, 2024
@kashifest
Copy link
Member Author

/test metal3-ubuntu-e2e-integration-test-main metal3-centos-e2e-integration-test-main

@kashifest kashifest changed the title 🌱 WIP: Use CAPI's remote cluster client and ClusterCacheTracker WIP: 🌱 Use CAPI's remote cluster client and ClusterCacheTracker Aug 18, 2024
@metal3-io-bot metal3-io-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 18, 2024
Signed-off-by: Kashif Khan <[email protected]>
@kashifest kashifest force-pushed the kashif/clusterCacheTracker-QPS-burst branch from 19f9833 to e83192c Compare August 20, 2024 09:59
@kashifest
Copy link
Member Author

/test metal3-ubuntu-e2e-integration-test-main metal3-centos-e2e-integration-test-main

@kashifest kashifest changed the title WIP: 🌱 Use CAPI's remote cluster client and ClusterCacheTracker WIP: 🌱 Use CAPI's ClusterCacheTracker Aug 20, 2024
@kashifest
Copy link
Member Author

/test metal3-centos-e2e-integration-test-main

@kashifest kashifest changed the title WIP: 🌱 Use CAPI's ClusterCacheTracker 🌱 Use CAPI's ClusterCacheTracker Aug 26, 2024
@metal3-io-bot metal3-io-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 26, 2024
Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Nice work!

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Sunnatillo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2024
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2024
@metal3-io-bot metal3-io-bot merged commit dd95969 into metal3-io:main Sep 16, 2024
25 checks passed
@metal3-io-bot metal3-io-bot deleted the kashif/clusterCacheTracker-QPS-burst branch September 16, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants