-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Use CAPI's ClusterCacheTracker #1911
🌱 Use CAPI's ClusterCacheTracker #1911
Conversation
/test metal3-ubuntu-e2e-integration-test-main metal3-centos-e2e-integration-test-main |
Signed-off-by: Kashif Khan <[email protected]>
19f9833
to
e83192c
Compare
/test metal3-ubuntu-e2e-integration-test-main metal3-centos-e2e-integration-test-main |
/test metal3-centos-e2e-integration-test-main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Nice work!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Sunnatillo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
This PR intends to use CAPI's ClusterCacheTracker kubernetes-sigs/cluster-api#8744. However, since CAPM3 didn't use CAPI's remote NewClusterClient previously, this has to be done in two steps. Once this PR merges we can remove CAPM3's infra remote code and use CAPI's ClusterCacheTracker consistently.