🌱 Use ClusterCacheTracker consistently (instead of NewClusterClient) #8744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
sbueringer
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
|
/test pull-cluster-api-e2e-full-main |
sbueringer
force-pushed
the
pr-use-clustercachetracker-consistently
branch
from
f6b1b07 to
b42793e
Compare
sbueringer
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
This PR is ready for review but I want to hold merging it so we can easily do a before/after comparison with the goofy provider. /assign @fabriziopandini @killianmuldoon @ykakarap |
k8s-ci-robot
added
the
do-not-merge/hold
|
/test pull-cluster-api-e2e-full-main |
Signed-off-by: Stefan Büringer [email protected]
sbueringer
force-pushed
the
pr-use-clustercachetracker-consistently
branch
from
b42793e to
051b006
Compare
|
Nice cleanup! |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: be91c8c1cf48f2a8c1962e10efd29fdb1aa11772
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
k8s-ci-robot
added
the
area/clustercachetracker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
We still had a few places left where we created clients for the workload cluster via
NewClusterClientinstead of using ClusterCacheTracker. This PR replaces the last usages ofNewClusterClient.I expect that it's more efficent to use a cached client vs re-creating it all the time
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #