Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Bump golang to v1.21.7 #1497

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

adilGhaffarDev
Copy link
Member

@adilGhaffarDev adilGhaffarDev commented Mar 4, 2024

What this PR does / why we need it:
Golang 1.20 is out of support in Feb 2024. Bumping golang image only in dockerfile, but not go.mod because it will break library consumers. We are following CAPI in this regard: kubernetes-sigs/cluster-api#9415

Signed-off-by: muhammad adil ghaffar <[email protected]>
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 4, 2024
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 4, 2024
@tuminoid
Copy link
Member

tuminoid commented Mar 4, 2024

/hold
When main bumped golang from 1.20 to 1.21 here it was a LOT of other changes. Why here we can just bump the image and be done?

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 4, 2024
@tuminoid
Copy link
Member

tuminoid commented Mar 4, 2024

As discussed offline, please update description to properly give background for skipping #1435 content in this bump, then feel free to unhold.

@adilGhaffarDev
Copy link
Member Author

/unhold @tuminoid please check

Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@adilGhaffarDev
Copy link
Member Author

/test-ubuntu-e2e-integration-release-1-5

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 4, 2024
@tuminoid
Copy link
Member

tuminoid commented Mar 4, 2024

/unhold
Added the ultimate reason why we bump it in the first place.

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 4, 2024
@metal3-io-bot metal3-io-bot merged commit 58a7d2a into metal3-io:release-1.5 Mar 4, 2024
21 checks passed
@metal3-io-bot metal3-io-bot deleted the bump-go-12.1-v1.5/adil branch March 4, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants