Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Bump golang to v1.21.6 #1435

Merged
merged 1 commit into from
Jan 30, 2024
Merged

🌱 Bump golang to v1.21.6 #1435

merged 1 commit into from
Jan 30, 2024

Conversation

kashifest
Copy link
Member

as the title says

@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 29, 2024
@kashifest
Copy link
Member Author

/hold
this requires project-infra patch as well

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 29, 2024
@kashifest
Copy link
Member Author

/test-ubuntu-integration-main
/test-centos-e2e-integration-main

@kashifest
Bump golang to v1.21.6
704e645 
Signed-off-by: Kashif Khan <[email protected]>
@kashifest
Copy link
Member Author

/test-ubuntu-integration-main
/test-centos-e2e-integration-main

1 similar comment
@kashifest
Copy link
Member Author

/test-ubuntu-integration-main
/test-centos-e2e-integration-main

@smoshiur1237
Copy link
Member

smoshiur1237 commented Jan 30, 2024 •
edited
Loading

Is this PR needs the project-infra PR to merge first? The gomod test is failing because of new go version.

tuminoid
tuminoid reviewed Jan 30, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

hack/ensure-go.sh
35:    minimum_go_version=go1.20

Missed this, otherwise LGTM.

@tuminoid
Copy link
Member

Is this PR needs the project-infra PR to merge first? The gomod test is failing because of new go version.

Project infra needs to go first whenever Prow test is broken/changed.

@kashifest
Copy link
Member Author 

hack/ensure-go.sh
35:    minimum_go_version=go1.20

Missed this, otherwise LGTM.

Intentionally left out since the PR job was failing, will bump it in a followup

tuminoid
tuminoid reviewed Jan 30, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Tests will start passing when project-infra one is merged.

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2024
@kashifest
Copy link
Member Author

/test gomod

@kashifest
Copy link
Member Author

/cc @mboukhalfa @lentzi90

mboukhalfa
mboukhalfa reviewed Jan 30, 2024
View reviewed changes
controllers/metal3data_controller_test.go
@@ -80,11 +80,11 @@ var _ = Describe("Metal3Data manager", func() {
}
if tc.m3d != nil && !tc.m3d.DeletionTimestamp.IsZero() {
if tc.releaseLeasesRequeue {
m.EXPECT().ReleaseLeases(context.TODO()).Return(baremetal.WithTransientError(errors.New(""), requeueAfter))
m.EXPECT().ReleaseLeases(context.Background()).Return(baremetal.WithTransientError(errors.New(""), requeueAfter))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was changing the context from todo to background required by the new go version ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the function uses context background but the test was expecting context todo

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is thrown as an error now with go 1.21

@mboukhalfa
Copy link
Member

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboukhalfa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2024
@kashifest
Copy link
Member Author

/hold cancel

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 30, 2024
@metal3-io-bot metal3-io-bot merged commit 83bbc1e into metal3-io:main Jan 30, 2024
19 checks passed
@metal3-io-bot metal3-io-bot deleted the bump/gov1.21 branch January 30, 2024 13:45
@tuminoid tuminoid mentioned this pull request Feb 7, 2024
Closed
This was referenced Mar 4, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mboukhalfa mboukhalfa mboukhalfa left review comments

@tuminoid tuminoid tuminoid left review comments

@lentzi90 lentzi90 Awaiting requested review from lentzi90

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kashifest @smoshiur1237 @tuminoid @mboukhalfa @metal3-io-bot