This repository has been archived by the owner on Mar 24, 2020. It is now read-only.
Fix RBAC generation from the code. #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A previous commit from PR metal3-io#6 added directives in the code for setting ClusterRole permissions. This commit adds the corresponding necessary change to the Makefile to act on those directives. This corresponds to the following PR from cluster-api's provider implementation documentation: kubernetes-sigs/cluster-api#779 Signed-off-by: Russell Bryant <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A previous commit from PR #6 added directives in the code for setting
ClusterRole permissions. This commit adds the corresponding necessary
change to the Makefile to act on those directives.
This corresponds to the following PR from cluster-api's provider
implementation documentation:
kubernetes-sigs/cluster-api#779
Signed-off-by: Russell Bryant [email protected]