Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[book] Fix rbac of the provider implementations in the book #779

Merged
merged 1 commit into from
Feb 28, 2019
Merged

[book] Fix rbac of the provider implementations in the book #779

merged 1 commit into from
Feb 28, 2019

Conversation

yangy2000
Copy link
Contributor

Signed-off-by: Alex Yang [email protected]

What this PR does / why we need it:
For the provider implementations in the book,

  1. ClusterRole permissions were added in PR Add directives for setting ClusterRole permissions in the book #750. But the Makefile only generates crds. It should generate RBAC from the code also.
  2. kubebuilder adds "--metrics-addr" flag in manager_auth_proxy_patch.yaml for now. But this flag was not mentioned in register_schemes.md.
  3. Replace blanks with TAB in Makefile.

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 26, 2019
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 26, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @yangy2000. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 26, 2019
@detiber
Copy link
Member

detiber commented Feb 26, 2019

/assign @davidewatson

@detiber
Copy link
Member

detiber commented Feb 26, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 26, 2019
@detiber
Copy link
Member

detiber commented Feb 27, 2019

/assign @davidewatson
/assign @vincepri

vincepri
vincepri approved these changes Feb 27, 2019
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Leaving LGTM to @davidewatson.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri, yangy2000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 27, 2019
@davidewatson
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2019
@detiber
Copy link
Member

detiber commented Feb 28, 2019

/test pull-cluster-api-integration

@k8s-ci-robot k8s-ci-robot merged commit f8d548b into kubernetes-sigs:master Feb 28, 2019
russellb added a commit to russellb/cluster-api-provider-baremetal that referenced this pull request Mar 6, 2019
@russellb
Fix RBAC generation from the code.
31c186f 
A previous commit from PR metal3-io#6 added directives in the code for setting
ClusterRole permissions.  This commit adds the corresponding necessary
change to the Makefile to act on those directives.

This corresponds to the following PR from cluster-api's provider
implementation documentation:

kubernetes-sigs/cluster-api#779

Signed-off-by: Russell Bryant <[email protected]>
@russellb russellb mentioned this pull request Mar 6, 2019
Merged
@yangy2000 yangy2000 deleted the fix_rbac_in_book branch September 5, 2019 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidewatson davidewatson davidewatson left review comments

@detiber detiber detiber left review comments

@figo figo figo left review comments

@vincepri vincepri vincepri approved these changes

@justinsb justinsb Awaiting requested review from justinsb

@krousey krousey Awaiting requested review from krousey

Assignees

@vincepri vincepri

@davidewatson davidewatson

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yangy2000 @k8s-ci-robot @detiber @davidewatson @figo @vincepri