Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 E2E: Specify checksum for live-iso #2103

Closed
wants to merge 2 commits into from

Conversation

lentzi90
Copy link
Member

@lentzi90 lentzi90 commented Dec 5, 2024

What this PR does / why we need it:

The test is currently failing because the checksum is missing.
See https://github.com/metal3-io/baremetal-operator/actions/workflows/e2e-test-periodic-main.yml

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from lentzi90. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot requested review from Rozzii and zaneb December 5, 2024 13:22
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 5, 2024
The test is currently failing because the checksum is missing.

Signed-off-by: Lennart Jern <[email protected]>
@lentzi90 lentzi90 force-pushed the lentzi90/e2e-live-iso-hash branch from 38d420d to 0e3dc21 Compare December 5, 2024 13:28
@lentzi90
Copy link
Member Author

lentzi90 commented Dec 5, 2024

/cc @kashifest @tuminoid

Signed-off-by: Lennart Jern <[email protected]>
@lentzi90
Copy link
Member Author

lentzi90 commented Dec 5, 2024

/hold
I will try specifying the checksum type also and see if that helps

@metal3-io-bot metal3-io-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 5, 2024
@lentzi90
Copy link
Member Author

lentzi90 commented Dec 9, 2024

/close
See #2110 instead

@metal3-io-bot
Copy link
Contributor

@lentzi90: Closed this PR.

In response to this:

/close
See #2110 instead

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@lentzi90 lentzi90 deleted the lentzi90/e2e-live-iso-hash branch December 9, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants