🐛 Add missing update permissions for HostUpdatePolicy CR to BMH controller

[pszczerbik]

This PR fixes node servicing by adding a missing update permission for HostUpdatePolicy CR to BMH controller.

Fixes #2097

[metal3-io-bot]

Hi @pszczerbik. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[pszczerbik]

Hi @rhjanders @iurygregory @dtantsur. Based on git log you have been recently working on node servicing support. Could you take a look at this PR?

Thanks,
Przemek

[rhjanders]

This looks reasonable. Downstream already has such RBACs:
https://github.com/openshift/baremetal-operator/blob/master/config/base/rbac/role.yaml#L78
https://github.com/openshift/baremetal-operator/blob/master/controllers/metal3.io/baremetalhost_controller.go#L106

[dtantsur]

/ok-to-test

[dtantsur]

/approve

[metal3-io-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dtantsur]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[iurygregory]

/lgtm

[pszczerbik]

/retest

[pszczerbik]

@dtantsur it seems that Live ISO test is timing-out:

[FAILED] Timed out after 600.001s. The function passed to Eventually failed at /home/runner/work/baremetal-operator/baremetal-operator/test/e2e/common.go:83 with: Expected <v1alpha1.ProvisioningState>: provisioning to equal <v1alpha1.ProvisioningState>: provisioned

I don't think this failure is related to my change. Perhaps wait-provisioned time out value needs to be increased.
How do you want to proceed? Should I just keep re-testing until it passes?

[tuminoid]

@dtantsur it seems that Live ISO test is timing-out:

[FAILED] Timed out after 600.001s. The function passed to Eventually failed at /home/runner/work/baremetal-operator/baremetal-operator/test/e2e/common.go:83 with: Expected <v1alpha1.ProvisioningState>: provisioning to equal <v1alpha1.ProvisioningState>: provisioned

I don't think this failure is related to my change. Perhaps wait-provisioned time out value needs to be increased. How do you want to proceed? Should I just keep re-testing until it passes?

We're debugging the live-iso test. E2E reports:

[Updated Event] live-iso-ops-0y2mh3/ProvisioningError-rb67j
	resource: metal3.io/v1alpha1/BareMetalHost/live-iso-ops
	reason: ProvisioningError
	message: Image provisioning failed: Deploy step deploy.deploy failed: The requested image is not valid for use..

since 2 days ago.

So hang on a while, and we'll get it sorted out.

[tuminoid]

So hang on a while, and we'll get it sorted out.

It should be fixed when #2103 merges and you rebase.

[tuminoid]

So hang on a while, and we'll get it sorted out.

It should be fixed when #2103 merges and you rebase.

Fix is actually done upstream Ironic side, but workaround #2112 has been merged. Please rebase.

[tuminoid]

So hang on a while, and we'll get it sorted out.

It should be fixed when #2103 merges and you rebase.

Fix is actually done upstream Ironic side, but workaround #2112 has been merged. Please rebase.

OK, workflow pulled the latest definitions from head, no rebase needed. Cheers!

[pszczerbik]

So hang on a while, and we'll get it sorted out.

It should be fixed when #2103 merges and you rebase.

Fix is actually done upstream Ironic side, but workaround #2112 has been merged. Please rebase.

OK, workflow pulled the latest definitions from head, no rebase needed. Cheers!

I was in a process of doing rebase, but Metal3 bot was faster than me. Cheers!