Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pin grafana-logging to 8.5 #1760

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

gracedo
Copy link
Contributor

@gracedo gracedo commented Dec 6, 2023

What problem does this PR solve?:
Pin grafana-logging to 8.5.26 which is the latest functioning version of grafana that loads the kubernetes audit dashboard successfully. Using 9+ causes the dashboard to crash upon loading, and after fixing the mem to avoid the crash, only the audit logs panel shows data. In interest of time and release timeline, let's just use grafana 8.5 and continue to investigate why newer grafana versions are causing these issues.

Which issue(s) does this PR fix?:

https://d2iq.atlassian.net/browse/D2IQ-99725

Special notes for your reviewer:

image

Does this PR introduce a user-facing change?:


Checklist

  • If the PR adds a version bump, ensure there is no breaking change in Licensing model (or NA).
  • If a chart is changed or app configuration is significantly changed, the chart version is correctly incremented (so that apps are not automatically upgraded from a previous version of DKP).

@gracedo gracedo added ready-for-review ok-to-test Signals mergebot that CI checks are ready to be kicked off backport-pr This is a backport PR labels Dec 6, 2023
@gracedo gracedo self-assigned this Dec 6, 2023
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 6, 2023
@d2iq-mergebot
Copy link
Contributor

This repo has @d2iq-mergebot integration. You can perform the following commands by submitting a comment. Submit a comment with content "@d2iq-mergebot help" to view more detailed help text and examples. Be sure the have a look at the mergebot documentation, too.For help using mergebot, please refer to the README file here: https://github.com/mesosphere/mergebot/blob/main/README.md
Enabled Mergebot commands:
@d2iq-mergebot test all
@d2iq-mergebot test
@d2iq-mergebot override-status
@d2iq-mergebot help
@d2iq-mergebot backport

@gracedo gracedo added the update-licenses signals mergebot to update licenses.d2iq.yaml label Dec 6, 2023
Copy link
Contributor

@msdolbey msdolbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
We'd like to resolve this in a peaceful way

@gracedo gracedo requested a review from takirala December 6, 2023 20:46
@gracedo
Copy link
Contributor Author

gracedo commented Dec 7, 2023

@d2iq-mergebot backport main

@gracedo gracedo enabled auto-merge (squash) December 7, 2023 17:36
@gracedo gracedo merged commit 9642459 into release-2.7 Dec 7, 2023
24 checks passed
@gracedo gracedo deleted the gracedo/release-2.7/logging_mem_D2IQ-99725 branch December 7, 2023 17:42
github-actions bot pushed a commit that referenced this pull request Dec 7, 2023
* fix: Pin grafana-logging to 8.5

* feat: Add grafana 8.5.26 image to licenses

(cherry picked from commit 9642459)
Copy link
Contributor

github-actions bot commented Dec 7, 2023

💚 All backports created successfully

Status Branch Result
main

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@gracedo gracedo mentioned this pull request Jan 2, 2024
2 tasks
gracedo added a commit that referenced this pull request Jan 2, 2024
* fix: Pin grafana-logging to 8.5

* feat: Add grafana 8.5.26 image to licenses

(cherry picked from commit 9642459)
@gracedo gracedo mentioned this pull request Jan 2, 2024
2 tasks
gracedo added a commit that referenced this pull request Jan 10, 2024
* fix: Pin grafana-logging to 8.5

* feat: Add grafana 8.5.26 image to licenses

(cherry picked from commit 9642459)
gracedo added a commit that referenced this pull request Jan 10, 2024
* fix: Pin grafana-logging to 8.5

* feat: Add grafana 8.5.26 image to licenses

(cherry picked from commit 9642459)

Co-authored-by: Grace Do <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport backport-pr This is a backport PR backport-to-main ok-to-test Signals mergebot that CI checks are ready to be kicked off ready-for-review size/S Denotes a PR that changes 10-29 lines, ignoring generated files. update-licenses signals mergebot to update licenses.d2iq.yaml
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants