Retry requests when setting Grafana's home dashboard #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The job that sets Grafana's home dashboard may run before Grafana's API is ready.
|
CI is giving this PR the same spurious error as #377 (comment). Likewise, |
GoelDeepak
approved these changes
Jan 23, 2020
gracedo
approved these changes
Jan 23, 2020
|
The CI error is fixed by #379 |
mesosphere-teamcity
pushed a commit
that referenced
this pull request
Jan 23, 2020
…uests when setting Grafana's home dashboard
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mesosphere.com/browse/DCOS-62216
This fixes an issue that may cause the Grafana home dashboard to be empty. If the job that sets Grafana's home dashboard runs before Grafana's API is ready, it will fail after one attempt. This PR changes the job to retry requests that fail with transient errors.
Testing
I tested this PR by deploying a Konvoy cluster with the prometheus and prometheusadapter addons disabled, deploying the prometheus-operator chart from this branch, browsing to
/ops/portal/grafana, and observing that the home dashboard is set to "Kubernetes / Compute Resources / Cluster".