Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

prometheus: bump prometheus-operator #96

Merged
merged 2 commits into from
Jan 24, 2020

Conversation

branden
Copy link
Contributor

@branden branden commented Jan 23, 2020

https://jira.mesosphere.com/browse/DCOS-62216

This bumps the prometheus-operator chart to pull in mesosphere/charts#377 and mesosphere/charts#378.

--- addons/prometheus/0.34.x/prometheus-1.yaml	2020-01-23 13:38:45.000000000 -0800
+++ addons/prometheus/0.34.x/prometheus-2.yaml	2020-01-23 13:39:40.000000000 -0800
@@ -38,7 +38,7 @@
   chartReference:
     chart: prometheus-operator
     repo: https://mesosphere.github.io/charts/staging
-    version: 8.3.7
+    version: 8.3.9
     values: |
       ---
       defaultRules:

Testing

I tested this PR by deploying a konvoy cluster with the config version/repo set to this branch, browsing to /ops/portal/grafana, and observing that the home dashboard is set to "Kubernetes / Compute Resources / Cluster".

gracedo
gracedo previously approved these changes Jan 23, 2020
Copy link
Contributor

@alejandroEsc alejandroEsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would count as a revision bump, and not just a change in version here. @shaneutt

Copy link
Contributor

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to make a new addon revision for this change, rather than changing the previous revision in line. Let us know if you need any help with that otherwise the documentation should cover it and there are examples amongst some of the other addons.

GoelDeepak
GoelDeepak previously approved these changes Jan 23, 2020
shaneutt
shaneutt previously approved these changes Jan 23, 2020
@shaneutt shaneutt requested a review from alejandroEsc January 23, 2020 21:44
alejandroEsc
alejandroEsc previously approved these changes Jan 23, 2020
Copy link
Contributor

@alejandroEsc alejandroEsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thank you!

@shaneutt shaneutt dismissed stale reviews from alejandroEsc and themself via 9b8de4c January 23, 2020 21:55
@shaneutt
Copy link
Contributor

I just realized, does this change actually update the app version? if so we need to update the metadata relevant to that version (app version AND revision)

@branden
Copy link
Contributor Author

branden commented Jan 23, 2020

No changes to the app version with this chart update. It only pulls in changes to the chart itself.

@shaneutt shaneutt merged commit e1b34f6 into d2iq-archive:master Jan 24, 2020
@branden branden deleted the bump-prom branch January 24, 2020 19:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants