-
Notifications
You must be signed in to change notification settings - Fork 21
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this would count as a revision bump, and not just a change in version here. @shaneutt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will need to make a new addon revision for this change, rather than changing the previous revision in line. Let us know if you need any help with that otherwise the documentation should cover it and there are examples amongst some of the other addons.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome, thank you!
I just realized, does this change actually update the app version? if so we need to update the metadata relevant to that version (app version AND revision) |
No changes to the app version with this chart update. It only pulls in changes to the chart itself. |
https://jira.mesosphere.com/browse/DCOS-62216
This bumps the prometheus-operator chart to pull in mesosphere/charts#377 and mesosphere/charts#378.
Testing
I tested this PR by deploying a konvoy cluster with the config version/repo set to this branch, browsing to
/ops/portal/grafana
, and observing that the home dashboard is set to "Kubernetes / Compute Resources / Cluster".