Clearer logs around building and deploying go apps #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janelletavares
requested review from
a team,
ericcheatham and
samirketema
and removed request for
a team
|
will rebase this after other things are merged... i think you're gonna like it. worth the wait. |
|
@janelletavares I've got this other refactor on |
janelletavares
force-pushed
the
go-ux-improvements
branch
from
442d8d4
to
0607020
Compare
janelletavares
commented
Apr 6, 2022
| @@ -328,7 +328,7 @@ func (d *Deploy) getPlatformImage(ctx context.Context, appPath string) (string, | |||
| return "", err | |||
| } | |||
|
|
|||
| fmt.Print("Getting status for build: ", build.Uuid) | |||
| fmt.Printf("Getting status for build: %s ", build.Uuid) | |||
There was a problem hiding this comment.
this just makes it easier to copy the uuid in Linux.. my personal preference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Fixes https://github.com/meroxa/turbine-project/issues/134
Type of change
How was this tested?
Demo
Additional references
Documentation updated