feat: apps deploy improvements #301
Conversation
raulb
force-pushed
the
raul/apps-deploy-combined
branch
5 times, most recently
from
73e67f4 to
e22baef
Compare
raulb
force-pushed
the
raul/apps-deploy-combined
branch
2 times, most recently
from
1c8cc6b to
7d52615
Compare
raulb
force-pushed
the
raul/apps-deploy-combined
branch
4 times, most recently
from
93262fc to
520aa58
Compare
raulb
changed the title
raulb
force-pushed
the
raul/apps-deploy-combined
branch
from
520aa58 to
c347110
Compare
- chore: Make dockerhub deployment generic - fix: Feature flag error - chore: Small refactor on build cmds - feat: Include how to inspect logs of failed build - fix: Avoid empty lines when not necessary - feat: Improve error message when invalid token before: ``` $ meroxa anything Error: Post "https://api.meroxa.io/v1/sources": oauth2: cannot fetch token: 403 Forbidden Response: {"error":"invalid_grant","error_description":"Unknown or invalid refresh token."} ``` after: ``` $ meroxa anything Error: unknown or invalid refresh token, please run `meroxa login` again ``` - feat: Add spinner to logger - feat: Include language on deploy output - feat: Add language validation - feat: include dashboard url
raulb
force-pushed
the
raul/apps-deploy-combined
branch
from
c347110 to
aa21e98
Compare
|
the something-bad-happened emojis don't look like anything in linux. i'm using bash. my editor just has an empty block where they should be, as well. |
|
|
||
| d.path, err = turbineCLI.GetPath(d.flags.Path) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| d.appName = path.Base(d.path) |
There was a problem hiding this comment.
this wasn't true with the example apps. I'm in the process of updating them, however.
|
@raulb I'm finished reviewing and testing. Let me know if you want to discuss anything that I pushed in my commits. |
There was a problem hiding this comment.
This reads great! I tested this in combination with the turbine-js branch james/fix-deploy-past-n-future and this seems to return an error when using the meroxa apps deploy command when deploying a JS app
I'm unsure if this is related to the Turbine lib or the CLI changes though, what do you think?
Deploy with --path
Deploy from current directory
There was a problem hiding this comment.
I just noticed after looking into this more that this is working as expected and that app deployments only fail under certain circumstances unrelated to this change
This reads great and works well, thank you for the super swift fix! ✨
Just a heads up, that I tracked the unrelated issue as a bug ticket here
Description of change
Fixes https://github.com/meroxa/turbine-project/issues/132
Type of change
How was this tested?
Demo
See slack! I recorded a couple.