Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connectors) Add ability to update name and configuration #190

Merged
merged 5 commits into from
Sep 6, 2021

Conversation

raulb
Copy link
Member

@raulb raulb commented Sep 3, 2021

Description of change

Fixes meroxa/product#143 and meroxa/product#105

Type of change

  • New feature
  • Bug fix
  • Refactor
  • Documentation

TODO

How was this tested?

  • Unit Tests
  • Tested in staging

Demo

Before this pull-request

❯ .m connectors update resource-942792-2630-984998 --name my-connector
Error: unknown flag: --name

After this pull-request

❯ .m connectors ls
  ID               NAME                  TYPE                        STREAMS                      STATE    PIPELINE
====== ============================= ============= ============================================ ========= ==========
 2231   resource-942792-2630-984998   jdbc-source   (output) resource-2630-133274-public.Users   pending   default

❯ .m connectors update resource-942792-2630-984998 --name my-connector
Updating connector "resource-942792-2630-984998"...
Connector "resource-942792-2630-984998" successfully updated!

❯ .m connectors ls
  ID        NAME          TYPE                        STREAMS                      STATE    PIPELINE
====== ============== ============= ============================================ ========= ==========
 2231   my-connector   jdbc-source   (output) resource-2630-133274-public.Users   pending   default

Additional references

⚠️ We should consider renaming the global config flag to avoid collisions with local --config options for connectors.

Documentation updated

Will create a changelog mentioning this change and also #189 so we can make one release with both changes on connectors.

Draft lives here: https://github.com/meroxa/meroxa-docs/pull/37

@raulb raulb self-assigned this Sep 3, 2021
@raulb raulb merged commit 3e6660a into master Sep 6, 2021
@raulb raulb deleted the raul/fix-product-143 branch September 6, 2021 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants