feat: Makes pipeline name required when creating connectors #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulb
changed the title
9 tasks
Fixes meroxa/product#128 It also makes ID to be a valid input when creating pipelines
I believe this should be changed everywhere so users know accurately when it can be an ID or not.
raulb
force-pushed
the
raul/pipeline-required
branch
from
e10246b to
b434b2b
Compare
raulb
requested review from
dianadoherty and
lovromazgon
and removed request for
anaptfox
dianadoherty
approved these changes
Sep 7, 2021
|
I just realized this needed more work for the |
raulb
added a commit
that referenced
this pull request
Sep 8, 2021
Something I forgot to push in #189 :hide:
6 tasks
raulb
added a commit
that referenced
this pull request
Sep 9, 2021
* feat: Make pipeline required creating connectors Fixes meroxa/product#128 It also makes ID to be a valid input when creating pipelines * fix: Accept pipeline names only for now I believe this should be changed everywhere so users know accurately when it can be an ID or not. * feat: Update message Something I forgot to push in #189 :hide: * feat: requires pipeline in connect Also updates wording
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Fixes https://github.com/meroxa/product/issues/128
Type of change
How was this tested?
Demo
Before this pull-request
After this pull-request
Documentation updated
https://github.com/meroxa/meroxa-docs/pull/37