Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NA_OFI: explictly complete NON-RECV OP in na_ofi_op_cancel for verbs #532

Closed
wants to merge 1 commit into from
Closed

NA_OFI: explictly complete NON-RECV OP in na_ofi_op_cancel for verbs #532

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/na/na_ofi.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3690,6 +3690,11 @@ na_ofi_op_cancel(struct na_ofi_op_id *na_ofi_op_id)
op, "fi_cancel() rc: %d (%s)", (int) rc, fi_strerror((int) -rc));
(void) rc;

if (na_ofi_op_id->na_ofi_class->domain->prov_type == NA_OFI_PROV_VERBS &&
na_ofi_op_id->completion_data.callback_info.type != NA_CB_RECV_UNEXPECTED &&
na_ofi_op_id->completion_data.callback_info.type != NA_CB_RECV_EXPECTED)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my concern is, if we need do this for NA_CB_PUT/GET?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the PUT/GET should be similar as send, it does not really can be canceled, but need to complete it .

na_ofi_complete(na_ofi_op_id, NA_CANCELED);

/* Work around segfault on fi_cq_signal() in some providers */
if (na_ofi_prov_flags[na_ofi_op_id->na_ofi_class->domain->prov_type] &
NA_OFI_SIGNAL) {
Expand Down