NA_OFI: explictly complete NON-RECV OP in na_ofi_op_cancel for verbs #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By kinds of testing, verbs provider will not generate complete event for the fi_cancel() for non-recv operations. This cause HG_Cancel() will not trigger RPC's completion as expected. This patch fixes it by na_ofi_complete() it for verbs provider. Signed-off-by: Xuezhao Liu <[email protected]>
gnailzenh
reviewed
Dec 9, 2021
| @@ -3690,6 +3690,11 @@ na_ofi_op_cancel(struct na_ofi_op_id *na_ofi_op_id) | |||
| op, "fi_cancel() rc: %d (%s)", (int) rc, fi_strerror((int) -rc)); | |||
| (void) rc; | |||
|
|
|||
| if (na_ofi_op_id->na_ofi_class->domain->prov_type == NA_OFI_PROV_VERBS && | |||
| na_ofi_op_id->completion_data.callback_info.type != NA_CB_RECV_UNEXPECTED && | |||
| na_ofi_op_id->completion_data.callback_info.type != NA_CB_RECV_EXPECTED) | |||
There was a problem hiding this comment.
my concern is, if we need do this for NA_CB_PUT/GET?
There was a problem hiding this comment.
the PUT/GET should be similar as send, it does not really can be canceled, but need to complete it .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By kinds of testing, verbs provider will not generate complete
event for the fi_cancel() for non-recv operations. This cause
HG_Cancel() will not trigger RPC's completion as expected.
This patch fixes it by na_ofi_complete() it for verbs provider.
Signed-off-by: Xuezhao Liu [email protected]