-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change colour attribute of InternalTag to string #684
base: master
Are you sure you want to change the base?
Conversation
Sandbox Executions
Run python/internal_tags.py through the sandbox.
Run javascript/internal_tag.js through the sandbox.
Run typescript/src/internal_tag.ts through the sandbox. |
Apply Sweep Rules to your PR?
|
Apply Sweep Rules to your PR?
|
The command:
|
🚀 Wrote ChangesDone. |
Sweep: internal_tag.ts is already there in typescript/src/entities/ folder |
🚀 Wrote ChangesDone. |
typescript/src/internal_tag.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweep: this file not need to be created
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Wrote Changes
I wasn't able to make changes. This could be due to an unclear request or a bug in my code.
As a reminder, comments on a file only modify that file. Comments on a PR (at the bottom of the "conversation" tab) can modify the entire PR. Please try again or contact us on Discord
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweep: just remove this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Wrote Changes
I wasn't able to make changes. This could be due to an unclear request or a bug in my code.
As a reminder, comments on a file only modify that file. Comments on a PR (at the bottom of the "conversation" tab) can modify the entire PR. Please try again or contact us on Discord
…sdk into sweep/change-colour-attribute
Description
This PR changes the data type of the 'colour' attribute in the 'InternalTag' class from integer to string in the Python, JavaScript, and TypeScript SDKs. The 'colour' attribute is updated to correctly represent colours in the RRGGBB format as strings.
Summary of Changes
python/internal_tags.py
:colour
attribute in theInternalTag
class to use theProperty(str)
data type.javascript/internal_tag.js
:colour
attribute in theInternalTag
class to use thestring
data type.typescript/src/internal_tag.ts
:colour
attribute in theInternalTag
class to use thestring
data type.These changes ensure that the 'colour' attribute in the 'InternalTag' class correctly represents colours in the RRGGBB format as strings, aligning with the desired functionality.
Fixes #682.
🎉 Latest improvements to Sweep:
💡 To get Sweep to edit this pull request, you can: