-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sweep: change colour internal tags from number to string #682
Comments
Here's the PR! #684.💎 Sweep Pro: I'm using GPT-4. You have unlimited GPT-4 tickets.
Actions (click)
Install Sweep Configs: Pull Request
Step 1: 🔎 SearchingI found the following snippets in your repository. I will now analyze these snippets and come up with a plan. Some code snippets I looked at (click to expand). If some file is missing from here, you can mention the path in the ticket description.Lines 1 to 39 in 6c0a2f3
Lines 1 to 26 in 6c0a2f3
Lines 1 to 40 in 6c0a2f3
Lines 1 to 42 in 6c0a2f3
Step 2: ⌨️ Coding
Modify python/internal_tags.py with contents:
Run python/internal_tags.py through the sandbox.
Modify javascript/internal_tag.js with contents:
Run javascript/internal_tag.js through the sandbox.
Create typescript/src/internal_tag.ts with contents:
Run typescript/src/internal_tag.ts through the sandbox. Step 3: 🔁 Code ReviewI have finished reviewing the code for completeness. I did not find errors for 🎉 Latest improvements to Sweep:
💡 To recreate the pull request edit the issue title or description. To tweak the pull request, leave a comment on the pull request. |
💎 Sweep Pro: I'm using GPT-4. You have unlimited GPT-4 tickets. Install Sweep Configs: Pull Request
Actions (click)
Step 1: 🔎 SearchingI found the following snippets in your repository. I will now analyze these snippets and come up with a plan. Some code snippets I looked at (click to expand). If some file is missing from here, you can mention the path in the ticket description.Lines 1 to 39 in 6c0a2f3
Lines 1 to 26 in 6c0a2f3
Lines 1 to 40 in 6c0a2f3
Lines 1 to 42 in 6c0a2f3
Step 2: ⌨️ Coding
Modify python/internal_tags.py with contents:
Run python/internal_tags.py through the sandbox.
Modify javascript/internal_tag.js with contents:
Run javascript/internal_tag.js through the sandbox.
Modify typescript/src/entities/internal_tag.ts with contents:
Run typescript/src/entities/internal_tag.ts through the sandbox. Step 3: 🔁 Code ReviewHere are my self-reviews of my changes at Here is the 1st review The changes in the python and typescript files are correctly implemented. However, the changes in the javascript file are missing. Please update the 'colour' attribute in the 'InternalTag' class in the javascript/internal_tag.js file from 'number' to 'string'. I'm currently addressing these suggestions. 🎉 Latest improvements to Sweep:
💡 To recreate the pull request edit the issue title or description. To tweak the pull request, leave a comment on the pull request. |
Here's the PR! #686.💎 Sweep Pro: I'm using GPT-4. You have unlimited GPT-4 tickets.
Actions (click)
Install Sweep Configs: Pull Request
Step 1: 🔎 SearchingI found the following snippets in your repository. I will now analyze these snippets and come up with a plan. Some code snippets I looked at (click to expand). If some file is missing from here, you can mention the path in the ticket description.Lines 1 to 39 in 6c0a2f3
Lines 1 to 26 in 6c0a2f3
Lines 1 to 40 in 6c0a2f3
Lines 1 to 42 in 6c0a2f3
Step 2: ⌨️ Coding
Modify python/internal_tags.py with contents:
Run python/internal_tags.py through the sandbox.
Modify javascript/internal_tag.js with contents:
Run javascript/internal_tag.js through the sandbox.
Create typescript/src/internal_tag.ts with contents:
Run typescript/src/internal_tag.ts through the sandbox. Step 3: 🔁 Code ReviewHere are my self-reviews of my changes at Here is the 1st review The changes made in the python and typescript files are correct and align with the issue request. However, the changes in the javascript file are missing. I finished incorporating these changes. 🎉 Latest improvements to Sweep:
💡 To recreate the pull request edit the issue title or description. To tweak the pull request, leave a comment on the pull request. |
Here's the PR! #685.💎 Sweep Pro: I'm using GPT-4. You have unlimited GPT-4 tickets.
Actions (click)
Install Sweep Configs: Pull Request
Step 1: 🔎 SearchingI found the following snippets in your repository. I will now analyze these snippets and come up with a plan. Some code snippets I looked at (click to expand). If some file is missing from here, you can mention the path in the ticket description.Lines 1 to 39 in 6c0a2f3
Lines 1 to 26 in 6c0a2f3
Lines 1 to 40 in 6c0a2f3
Lines 1 to 42 in 6c0a2f3
Step 2: ⌨️ Coding
Modify python/internal_tags.py with contents:
Run python/internal_tags.py through the sandbox.
Modify javascript/internal_tag.js with contents:
Run javascript/internal_tag.js through the sandbox.
Create typescript/src/internal_tag.ts with contents:
Run typescript/src/internal_tag.ts through the sandbox. Step 3: 🔁 Code ReviewI have finished reviewing the code for completeness. I did not find errors for 🎉 Latest improvements to Sweep:
💡 To recreate the pull request edit the issue title or description. To tweak the pull request, leave a comment on the pull request. |
the colour attribute of internal tags in python, typescript and javasript sdk are miss assigned to integer, change them into string
Checklist
python/internal_tags.py
✓ 149c1d1javascript/internal_tag.js
! No changes madetypescript/src/entities/internal_tag.ts
✓ 9745494The text was updated successfully, but these errors were encountered: