Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature 3625 zapwrapper read sechub config directly from env #3698

Merged

Conversation

- add possibility to read the PDS_SCAN_CONFIGURATION variable directly
- remove part in PDS solution where the content of PDS_SCAN_CONFIGURATION
  is written to a file before reading it
- refactoring/renaming
- remove rules data structure
- remove helper scripts and json example files
- update test cases
- update pds-owaspzap solution
@winzj winzj marked this pull request as ready for review December 3, 2024 09:11
@winzj winzj requested a review from de-jcup December 3, 2024 09:11
Copy link
Member

@de-jcup de-jcup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi good work, but I found some parts.
I approved it anyway, but please read my comments and do some changes.

@winzj winzj merged commit 2274af0 into develop Dec 5, 2024
2 checks passed
@winzj winzj deleted the feature-3625-zapwrapper-read-sechub-config-directly-from-env branch December 5, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants