Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify the rule deactivation for pds-owaspzap #3697

Closed
winzj opened this issue Nov 29, 2024 · 0 comments · Fixed by #3698
Closed

Simplify the rule deactivation for pds-owaspzap #3697

winzj opened this issue Nov 29, 2024 · 0 comments · Fixed by #3698
Assignees
@winzj
Labels
pds-solutions zap wrapper
Milestone
ZAP Wrapper 1.7.0

Comments

@winzj
Copy link
Member

winzj commented Nov 29, 2024

Situation

Currently a configuration file is required to deactivate rules for pds-owaspzap. This is too complicated to use and shall be simplified.

Wanted

A simple comma separated list of rule ids can be configured either via command line or ENV variable:

  • --deactivateRules 0,2
  • ZAP_DEACTIVATED_RULE_REFERENCES="0,2"
  • or via the executor config in SecHub: zap.deactivation.rule.references=0,2

Solution

  • remove all rule deactivation parts
  • introduce a list of ids mentioned in the section above
  • update the current imlementation to use the
  • make sure to use the ENV variable currently already available ZAP_DEACTIVATED_RULE_REFERENCES
@winzj winzj added this to the ZAP Wrapper 1.7.0 milestone Nov 29, 2024
@winzj winzj self-assigned this Nov 29, 2024
winzj added a commit that referenced this issue Nov 29, 2024
@winzj
Remove rule structure and replace with simplelist of ids #3697
b3e791d 
- remove rules data structure
- remove helper scripts and json example files
- update test cases
- update pds-owaspzap solution
@winzj winzj mentioned this issue Nov 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@winzj winzj

Labels
pds-solutions zap wrapper
Projects
None yet
Milestone
ZAP Wrapper 1.7.0
Development

Successfully merging a pull request may close this issue.

Feature 3625 zapwrapper read sechub config directly from env mercedes-benz/sechub
1 participant
@winzj