Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

partial function for keys method #70

Merged
merged 2 commits into from
Jul 26, 2022
Merged

partial function for keys method #70

merged 2 commits into from
Jul 26, 2022

Conversation

AlirezaSohofi
Copy link
Contributor

Description

This fixes a bug that causes PyTorch DataLoader to hang. keys() returns a generator, replacing it with a partial function would solve the issue.

Fixes # issue

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring including code style reformatting
  • Other (please describe):

Checklist:

  • I have read the contributing guideline doc (external contributors only)
  • Lint and unit tests pass locally with my changes
  • I have kept the PR small so that it can be easily reviewed
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • All dependency changes have been reflected in the pip requirement files.

Copy link
Contributor

@AlpAribal AlpAribal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after linting and tests pass.

__version__ = "0.15.0"
__version__ = "0.16.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think patch bump would also work here

@axkoenig
Copy link
Contributor

Tried and tested this. It fixes the bug, thanks @AlirezaSohofi!

axkoenig
axkoenig previously approved these changes Jul 26, 2022
pzdkn
pzdkn previously approved these changes Jul 26, 2022
Copy link
Contributor

@pzdkn pzdkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlirezaSohofi AlirezaSohofi dismissed stale reviews from pzdkn and axkoenig via 378a647 July 26, 2022 08:24
@AlirezaSohofi AlirezaSohofi merged commit 0b2b53c into main Jul 26, 2022
@AlirezaSohofi AlirezaSohofi deleted the bugfix_lazy_keys branch July 26, 2022 11:31
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants