Implement non_fast_start optimization in MP4 ISOM demuxer. #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he non_fast_start optimization. Change the File.SeekEvent into File.SeekSinkEvent.
…e_mp4_plugin into non_fast_start_demuxer
…orks properly with fast_start files. Fix a bug
…ramework/membrane_mp4_plugin into non_fast_start_demuxer
mat-hek
requested changes
Jul 18, 2023
lib/membrane_mp4/demuxer/isom.ex
Outdated
Comment on lines
143
to
161
| def handle_demand( | ||
| Pad.ref(:output, _track_id), | ||
| _size, | ||
| :buffers, | ||
| _ctx, | ||
| state | ||
| ) do | ||
| {[], state} | ||
| end | ||
|
|
||
| def handle_process( | ||
| :input, | ||
| _buffer, | ||
| _ctx, | ||
| %{ | ||
| fsm_state: fsm_state | ||
| } = state | ||
| ) | ||
| when fsm_state in [:mdat_skipping, :going_back_to_mdat] do |
There was a problem hiding this comment.
the formatting got quite bulky here
There was a problem hiding this comment.
I have improved it, done
lib/membrane_mp4/demuxer/isom.ex
Outdated
| {[], state} | ||
| def handle_event( | ||
| :input, | ||
| %Membrane.File.NewSeekEvent{}, |
lib/membrane_mp4/demuxer/isom.ex
Outdated
| end | ||
|
|
||
| defp handle_non_fast_start_optimization(%{fsm_state: :go_back_to_mdat} = state) do | ||
| seek(state, state.mdat_beginning, state.mdat_size + @header_size, true) |
There was a problem hiding this comment.
Suggested change
| seek(state, state.mdat_beginning, state.mdat_size + @header_size, true) | |
| seek(state, state.mdat_beginning, state.mdat_size + @header_size, false) |
lib/membrane_mp4/demuxer/isom.ex
Outdated
| end | ||
| end | ||
|
|
||
| defp update_fsm_state(state) do |
There was a problem hiding this comment.
as we discussed, add the context argument
… the formating less bulky
mat-hek
approved these changes
Jul 19, 2023
Comment on lines
+132
to
+151
| def handle_process( | ||
| :input, | ||
| _buffer, | ||
| _ctx, | ||
| %{ | ||
| fsm_state: fsm_state | ||
| } = state | ||
| ) | ||
| when fsm_state in [:mdat_skipping, :going_back_to_mdat] do | ||
| {[demand: :input], state} | ||
| end | ||
|
|
||
| @impl true | ||
| def handle_process( | ||
| :input, | ||
| buffer, | ||
| ctx, | ||
| %{all_pads_connected?: true, samples_info: %SamplesInfo{}} = state | ||
| %{ | ||
| fsm_state: :samples_info_present_and_all_pads_connected | ||
| } = state |
lib/membrane_mp4/demuxer/isom.ex
Outdated
| end | ||
| end | ||
|
|
||
| defp update_fsm_state(state, ctx \\ []) do |
There was a problem hiding this comment.
Context could be just an atom, a keyword list is overkill IMO. But do as you prefer
|
We need to wait until membraneframework/membrane_file_plugin#40 is merged and new version of membrane_file_plugin is released, so that we can change the deps in this PR |
…s with formats versions. Remove `blocking?: true` from `Pipeline.terminate`
mat-hek
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.