Seekable source #40
Merged
Seekable source #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Rename SeekEvent into SeekSinkEvent.
… event and extend the moduledoc for source.
mat-hek
requested changes
Jul 18, 2023
lib/membrane_file/source.ex
Outdated
Comment on lines
6
to
12
| Can work in two modes, determined by the `seekable?` option. | ||
| With `seekable?: false`, the source will start reading data from the file exactly the moment it starts | ||
| playing and will read it till the end of file, setting the `end_of_stream` action on the `:output` pad | ||
| when the reading is done. | ||
| With `seekable?: true`, the process of reading is driven by receiving `Membrane.File.SeekSourceEvent` events. | ||
| The source working in `seekable?: true` mode won't send any data before that event is received. | ||
| For more information about how to steer reading in `seekable?: true` mode, see: `Membrane.File.SeekSourceEvent`. |
There was a problem hiding this comment.
I'd only mention that its behaviour can be configured by the seekable option and put this in the option's description
lib/membrane_file/source.ex
Outdated
| ) do | ||
| @common_file.seek!(state.fd, seek_start) | ||
|
|
||
| {[event: {:output, %Membrane.File.NewSeekEvent{}}, redemand: :output], |
lib/membrane_file/source.ex
Outdated
Comment on lines
134
to
142
| if state.should_send_eos? and (state.size_to_read == 0 or supplied_size < to_supply_size) do | ||
| [end_of_stream: :output] | ||
| else | ||
| if to_supply_size == supplied_size do | ||
| redemand | ||
| else | ||
| [] | ||
| end | ||
| end |
mat-hek
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.