Ms 390 fix removing pads should pop ready frames #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bug was that the compositor used to not render any frames when sending an end of stream message to a video. This meant that in cases where all videos but one had frames for composing and then the one video received end of stream, frames would never be rendered. While fixing this problem, several serious bugs were discovered in the 'realtime mode' feature. We decided to remove it altogether since noone uses it anyway.
A video that was added to the compositor, but did not receive start of stream would also not receive end of strem when it's removed. This could cause the compositor to wait for the missing frames forever.
WojciechBarczynski
requested changes
Feb 15, 2023
Comment on lines
235
to
238
| defp is_pad_waiting_for_caps?(pad, state) do | ||
| pad_id = Map.get(state.pads_to_ids, pad) | ||
|
|
||
| Map.has_key?(state.initial_video_transformations, pad_id) |
There was a problem hiding this comment.
- Relying here on the logic that once the Video Compositor receives stream format from the input pad its
initial_video_transformationsare removed from the map kept instateby callingMap.pop(initial_video_transformations, id)is error-prone. This might break and produce hard-to-trace errors once we change logic related to video transformations. caps->stream_format
The renames were done in both the `WgpuAdapter` and `Native` modules.
Most private functions are also spec'ed. Also merge `initial_video_transformations` and `initial_placements` into a singular map with a more apt name -- `videos_waiting_for_stream_format`
WojciechBarczynski
requested changes
Feb 15, 2023
jerzywilczek
deleted the
MS-390-fix-removing-pads-should-pop-ready-frames
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug was that the compositor used to not render any frames when sending an end of stream message to a video. This meant that in cases where all videos but one had frames for composing and then the one video received end of stream, frames would never be rendered.
It also fixes a related issue caused by the fact that not all videos receive end of stream (those, which did not receive start of stream do not).
While fixing this problem, several serious bugs were discovered in the 'realtime mode' feature. We decided to remove it altogether since no one uses it anyway.
Closes #85