Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling pad removing #85

Closed
Karolk99 opened this issue Jan 31, 2023 · 0 comments · Fixed by #87
Closed

Handling pad removing #85

Karolk99 opened this issue Jan 31, 2023 · 0 comments · Fixed by #87

Comments

@Karolk99
Copy link
Contributor

Right now there is no handle_pad_removed callback in compositor_element.ex. This can cause problems when we get handle_pad_added without handle_start_of_stream in this scenario we won't always get "end_of stream" message.
That's why we have to implement 'handle_pad_removed` to be sure that we handle all cases of removing pads.

Also there is another problem with a stream that was collected but not mixed. If compositor_element get "end_of_stream" from certain pad it won't try to mix frames that were blocked by this pad so if we don't get any new buffers we will never mix those saved frames. My suggestion to fix that is to invoke some function that will try to mix as much frames as it can in two callbacks: handle_pad_removed and handle_end_of_stream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant