Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(templates): Install dependencies in CI and bump dev dependencies #1305

Merged
merged 6 commits into from
Jan 4, 2023
Merged

fix(templates): Install dependencies in CI and bump dev dependencies #1305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c2bd5bb
github action to install poetry deps before using them
pnadolny13 Jan 3, 2023
14c2060
poetry bump black to fix bug and migrate from deprecated dev to group…
pnadolny13 Jan 3, 2023
0f6d09a
Update the rest of the dependencies
edgarrmondragon Jan 3, 2023
5b15615
Merge branch 'main' into cookiecutter_bugfixes
edgarrmondragon Jan 3, 2023
ff688c6
Merge branch 'main' into cookiecutter_bugfixes
pnadolny13 Jan 4, 2023
a0abdbd
Merge branch 'main' into cookiecutter_bugfixes
edgarrmondragon Jan 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...ws/{% if cookiecutter.include_cicd_sample_template == 'GitHub' %}ci_workflow.yml{%endif%}
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,9 @@ jobs:
run: |
python -m pip install --upgrade pip
pip install poetry==1.2.*
- name: Install dependencies
run: |
poetry install
- name: Run lint command from tox.ini
run: |
poetry run tox -e lint
Expand Down
20 changes: 10 additions & 10 deletions cookiecutter/tap-template/{{cookiecutter.tap_id}}/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,20 +10,20 @@ keywords = [
license = "Apache 2.0"

[tool.poetry.dependencies]
python = "<3.11,>=3.7.1"
requests = "^2.25.1"
python = "<3.12,>=3.7.1"
requests = "^2.28.1"
singer-sdk = { version="^0.16.0"}
fs-s3fs = { version = "^1.1.1", optional = true}

[tool.poetry.dev-dependencies]
pytest = "^6.2.5"
tox = "^3.24.4"
[tool.poetry.group.dev.dependencies]
pytest = "^7.2.0"
tox = "^4.1.3"
flake8 = "^3.9.2"
black = "^21.9b0"
pydocstyle = "^6.1.1"
mypy = "^0.910"
types-requests = "^2.26.1"
isort = "^5.10.1"
black = "^22.12.0"
pydocstyle = "^6.2.1"
mypy = "^0.991"
types-requests = "^2.28.11.7"
isort = "^5.11.4"

[tool.poetry.extras]
s3 = ["fs-s3fs"]
Expand Down
2 changes: 1 addition & 1 deletion cookiecutter/tap-template/{{cookiecutter.tap_id}}/tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ envlist = py38
isolated_build = true

[testenv]
whitelist_externals = poetry
allowlist_externals = poetry

commands =
poetry install -v
Expand Down
18 changes: 9 additions & 9 deletions cookiecutter/target-template/{{cookiecutter.target_id}}/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,20 +10,20 @@ keywords = [
license = "Apache 2.0"

[tool.poetry.dependencies]
python = "<3.11,>=3.7.1"
requests = "^2.25.1"
python = "<3.12,>=3.7.1"
requests = "^2.28.1"
singer-sdk = { version="^0.16.0"}
fs-s3fs = { version = "^1.1.1", optional = true}

[tool.poetry.dev-dependencies]
pytest = "^6.2.5"
tox = "^3.24.4"
pytest = "^7.2.0"
tox = "^4.1.3"
flake8 = "^3.9.2"
black = "^21.9b0"
pydocstyle = "^6.1.1"
mypy = "^0.910"
types-requests = "^2.26.1"
isort = "^5.10.1"
black = "^22.12.0"
pydocstyle = "^6.2.1"
mypy = "^0.991"
types-requests = "^2.28.11.7"
isort = "^5.11.4"

[tool.poetry.extras]
s3 = ["fs-s3fs"]
Expand Down