Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(templates): Install dependencies in CI and bump dev dependencies #1305

Merged
merged 6 commits into from
Jan 4, 2023

Conversation

pnadolny13
Copy link
Contributor

@pnadolny13 pnadolny13 commented Jan 3, 2023

Closes #1223 and #1225

I ran into these same bugs when using the cookiecutter for https://github.com/pnadolny13/tap-cloudwatch and had to resolve them for my implementation. Heres what ended up working for me.

  • github action install poetry dependencies before running tox
  • bump black version
  • migrate from legacy poetry dev dependencies to group.dev. I removed black then readded it and poetry did this automatically for me with a warning.

📚 Documentation preview 📚: https://meltano-sdk--1305.org.readthedocs.build/en/1305/

@edgarrmondragon edgarrmondragon changed the title Cookiecutter bug fixes fix(templates): Install dependencies in CI and bump dev dependencies Jan 3, 2023
@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Merging #1305 (a0abdbd) into main (2773841) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1305   +/-   ##
=======================================
  Coverage   84.53%   84.53%           
=======================================
  Files          44       44           
  Lines        4190     4190           
  Branches      725      725           
=======================================
  Hits         3542     3542           
  Misses        474      474           
  Partials      174      174           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pnadolny13
Copy link
Contributor Author

@edgarrmondragon I saw that you made a few changes to this, is it good to go now?

@edgarrmondragon
Copy link
Collaborator

@pnadolny13 yeah this is good to go. Auto-merging...

@edgarrmondragon edgarrmondragon enabled auto-merge (squash) January 4, 2023 18:51
@pnadolny13
Copy link
Contributor Author

@edgarrmondragon I think its blocked by an approval from a code owner. Did we want others to review also?

@edgarrmondragon edgarrmondragon merged commit dfd2f7e into main Jan 4, 2023
@edgarrmondragon edgarrmondragon deleted the cookiecutter_bugfixes branch January 4, 2023 19:51
@edgarrmondragon
Copy link
Collaborator

@edgarrmondragon I think its blocked by an approval from a code owner. Did we want others to review also?

@pnadolny13 nope, just forgot to approve 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Cookiecutter black version out of date
2 participants