-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(templates): Install dependencies in CI and bump dev dependencies #1305
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1305 +/- ##
=======================================
Coverage 84.53% 84.53%
=======================================
Files 44 44
Lines 4190 4190
Branches 725 725
=======================================
Hits 3542 3542
Misses 474 474
Partials 174 174 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@edgarrmondragon I saw that you made a few changes to this, is it good to go now? |
@pnadolny13 yeah this is good to go. Auto-merging... |
@edgarrmondragon I think its blocked by an approval from a code owner. Did we want others to review also? |
@pnadolny13 nope, just forgot to approve 😅 |
Closes #1223 and #1225
I ran into these same bugs when using the cookiecutter for https://github.com/pnadolny13/tap-cloudwatch and had to resolve them for my implementation. Heres what ended up working for me.
📚 Documentation preview 📚: https://meltano-sdk--1305.org.readthedocs.build/en/1305/