Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added cookiecutter support and docs for VSCode debugging #968

Merged
merged 7 commits into from
Sep 15, 2022

Conversation

kgpayne
Copy link
Contributor

@kgpayne kgpayne commented Sep 14, 2022

Added module entry point to tap and target cookiecutters, and guidance on how to use them for debugging in VSCode.


📚 Documentation preview 📚: https://meltano-sdk--968.org.readthedocs.build/en/968/

Copy link
Collaborator

@edgarrmondragon edgarrmondragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kgpayne nice! Left a few suggestions

@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Merging #968 (8c436e8) into main (f74493d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #968   +/-   ##
=======================================
  Coverage   81.77%   81.77%           
=======================================
  Files          37       37           
  Lines        3742     3742           
  Branches      746      746           
=======================================
  Hits         3060     3060           
  Misses        500      500           
  Partials      182      182           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon edgarrmondragon changed the title feat: added fixtures and docs for vscode debugging feat: Added cookiecutter support and docs for VSCode debugging Sep 15, 2022
@edgarrmondragon edgarrmondragon self-requested a review September 15, 2022 14:04
@edgarrmondragon
Copy link
Collaborator

@kgpayne wdyt about adding the .vscode/launch.json file to the tap cookiecutter, perhaps conditioned on a new question?

@kgpayne
Copy link
Contributor Author

kgpayne commented Sep 15, 2022

@kgpayne wdyt about adding the .vscode/launch.json file to the tap cookiecutter, perhaps conditioned on a new question?

I don't have a strong sense of how popular vscode is relative to others like pycharm/vim/sublime/atom 🤔 @tayloramurphy do we have any IDE data from our user surveys?

Either way, I think adding docs/instructions for 1 or 2 other IDE's might be a good next step, then adding a new cookie cutter question when there are a couple of options to choose from 🙂 @pandemicsyn uses pycharm so may be able to contribute a snippet for that, and I believe @cjohnhanson uses vim.

Edit: created #973 to track additional IDE setup docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants