Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPUB CSS problems in Cool Reader, FBreader and other mobile applications #21

Open
link2xt opened this issue Mar 29, 2019 · 7 comments
Open

Comments

@link2xt
Copy link
Contributor

link2xt commented Mar 29, 2019

Failed attempts at fixing CSS: #19 #20

@link2xt
Copy link
Contributor Author

link2xt commented Mar 29, 2019

Just for reference, Cool Reader development has officially moved from SourceForge to GitHub: https://github.com/buggins/coolreader

@melmothx
Copy link
Owner

@link2xt here's the plan.

I'm going to revert the changes in #19 and #20 and cut a release, because I need the other feature sitting on master. Then I'm going to setup https://staging.amusewiki.org with a local css.tt template, and give you access, so you can do your development in the css.tt there (via git), and we can evaluate the changes looking at the same linkable files. If you need to open bugs against coolreader/fbreader, you can point to staging.

@melmothx melmothx changed the title Blockquotes are indistinguishable from the rest of the text in Cool Reader EPUB CSS problems in Cool Reader, FBreader and other mobile applications Mar 30, 2019
@melmothx
Copy link
Owner

@link2xt It's all set up. Please let me know if you have problems.

@link2xt
Copy link
Contributor Author

link2xt commented Apr 15, 2019

CoolReader has known CSS priority problems:
https://sourceforge.net/p/crengine/bugs/284/
https://sourceforge.net/p/crengine/bugs/230/
https://sourceforge.net/p/crengine/bugs/231/

Maybe reordering the rules can help.

I have also reported the problem with paragraphs inside list items: buggins/coolreader#90

@link2xt
Copy link
Contributor Author

link2xt commented Apr 20, 2019

Related change in KOReader, adding CSS specificity support: koreader/crengine#170

@link2xt
Copy link
Contributor Author

link2xt commented Apr 20, 2019

I have opened PR #22 that at least makes blockquotes distinguishable in Cool Reader. Long term solution is fixing the Cool Reader engine, though.

@link2xt
Copy link
Contributor Author

link2xt commented Jan 27, 2020

This needs to be tested again since buggins/coolreader#125 is merged and buggins/coolreader#91 is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants