Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge with KOReader fork of crengine #91

Closed
link2xt opened this issue Apr 15, 2019 · 1 comment · Fixed by #125
Closed

Merge with KOReader fork of crengine #91

link2xt opened this issue Apr 15, 2019 · 1 comment · Fixed by #125

Comments

@link2xt
Copy link

link2xt commented Apr 15, 2019

KOReader developers (ping @Frenzie @poire-z) maintain a fork of crengine: https://github.com/koreader/crengine/ Quick diff shows that there are list item display fixes (see #90), several new CSS properties support, fix for <cite> bug (https://sourceforge.net/p/crengine/bugs/268/) and other enhancements. Are there any plans to merge these fixes back into coolreader?

Related issue about another fork: koreader/crengine#267

(KOReader is great, but it focuses on e-ink devices, so it does not even support changing background color. For this reason, it can't be used as a drop-in replacement for CoolReader on Android.)

@Frenzie
Copy link

Frenzie commented Apr 16, 2019

To provide some context, upstream was regrettably inactive for several years, which led to our divergence from it. We've had good improvements in HTML and CSS conformance over at the KOReader fork during that time, as well as speed. (Plus some nifty additional features like user style tweaks.) Since this very GH repository revived upstream it has given us HarfBuzz, which is also very neat.

Our crengine code itself purposefully has diverged fairly little from its source material (or has used preprocessor statements, e.g., in koreader/crengine#282), so it might not be too problematic to integrate it with the updated Java/Qt frontends.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants