Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paragraphs inside list items are displayed on a separate line #90

Open
link2xt opened this issue Apr 15, 2019 · 3 comments
Open

Paragraphs inside list items are displayed on a separate line #90

link2xt opened this issue Apr 15, 2019 · 3 comments

Comments

@link2xt
Copy link

link2xt commented Apr 15, 2019

Here is an HTML file to reproduce the bug:

<?xml version="1.0" encoding="utf-8"?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN"
    "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en" dir="ltr">
<head>
  <meta http-equiv="Content-type" content="application/xhtml+xml; charset=UTF-8" />
  <title>List</title>
</head>
<body>

<ul>
  <li><p>Item 1.</p></li>
  <li><p>Item 2.</p></li>
  <li>Item 3.</li>
  <li><p>Item 4.</p></li>
</ul>

</body>
</html>

I opened it with cr3qt/cr3 and it is displayed as follows:
1

In Firefox, all list items look the same:
1

Same HTML packed in EPUB also displays incorrectly.
@link2xt link2xt mentioned this issue Apr 15, 2019
Open
@Frenzie
Copy link

Frenzie commented Apr 15, 2019

It'd be a good idea to look at the KOReader modifications in this matter. It renders correctly:

Screenshot_2019-04-15_20-59-24

(Add a <style>p {text-indent:1em}</style> to the document to give Fx the same styles as our defaults.)

@link2xt
Copy link
Author

link2xt commented Apr 15, 2019

Interesting, I did not know that KOReader is based on crengine.
A link for reference: https://github.com/koreader/crengine

@link2xt
Copy link
Author

link2xt commented Apr 15, 2019

I have compared this repo with https://github.com/koreader/crengine

It seems there are changes specifically fixing this bug in koreader: koreader/crengine@81b8707

@link2xt link2xt mentioned this issue Apr 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Frenzie @link2xt