Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose classes and utility is DryWetMidi.Multimedia #301

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Expose classes and utility is DryWetMidi.Multimedia #301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9272daf
changing visibility to allow easier custom playback implmentations
Jul 23, 2024
d5f162c
Merge branch 'develop' of https://github.com/noonesimg/drywetmidi int…
Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions DryWetMidi/Interaction/Notes/Note.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,12 +313,12 @@ public FourBitNumber Channel
/// <summary>
/// Gets Note On timed event of the note.
/// </summary>
internal TimedEvent TimedNoteOnEvent { get; } = new TimedEvent(new NoteOnEvent { Velocity = DefaultVelocity });
public TimedEvent TimedNoteOnEvent { get; } = new TimedEvent(new NoteOnEvent { Velocity = DefaultVelocity });

/// <summary>
/// Gets Note Off timed event of the note.
/// </summary>
internal TimedEvent TimedNoteOffEvent { get; } = new TimedEvent(new NoteOffEvent { Velocity = DefaultOffVelocity });
public TimedEvent TimedNoteOffEvent { get; } = new TimedEvent(new NoteOffEvent { Velocity = DefaultOffVelocity });

internal MusicTheory.Note UnderlyingNote => MusicTheory.Note.Get(NoteNumber);

Expand Down
6 changes: 3 additions & 3 deletions DryWetMidi/Interaction/Notes/NotesManagingUtilities.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1005,7 +1005,7 @@ internal static int ProcessNotesInternal(
return iMatched;
}

internal static IEnumerable<TimedObjectAt<ITimedObject>> GetNotesAndTimedEventsLazy(
public static IEnumerable<TimedObjectAt<ITimedObject>> GetNotesAndTimedEventsLazy(
this IEnumerable<TimedObjectAt<TimedEvent>> timedEvents,
NoteDetectionSettings settings)
{
Expand Down Expand Up @@ -1084,14 +1084,14 @@ internal static IEnumerable<TimedObjectAt<ITimedObject>> GetNotesAndTimedEventsL
}
}

internal static IEnumerable<ITimedObject> GetNotesAndTimedEventsLazy(
public static IEnumerable<ITimedObject> GetNotesAndTimedEventsLazy(
this IEnumerable<TimedEvent> timedEvents,
NoteDetectionSettings settings)
{
return GetNotesAndTimedEventsLazy(timedEvents, settings, false);
}

internal static IEnumerable<ITimedObject> GetNotesAndTimedEventsLazy(
public static IEnumerable<ITimedObject> GetNotesAndTimedEventsLazy(
this IEnumerable<ITimedObject> timedObjects,
NoteDetectionSettings settings,
bool completeObjectsAllowed)
Expand Down
2 changes: 1 addition & 1 deletion DryWetMidi/Interaction/TimedObject/TimedObjectAt.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
namespace Melanchall.DryWetMidi.Interaction
{
internal sealed class TimedObjectAt<TObject>
public class TimedObjectAt<TObject>
where TObject : ITimedObject
{
#region Constructor
Expand Down
6 changes: 3 additions & 3 deletions DryWetMidi/Multimedia/Playback/Callbacks/NotePlaybackData.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,18 +66,18 @@ private NotePlaybackData(bool playNote)
/// </summary>
public FourBitNumber Channel { get; }

internal bool PlayNote { get; }
public bool PlayNote { get; }

#endregion

#region Methods

internal NoteOnEvent GetNoteOnEvent()
public NoteOnEvent GetNoteOnEvent()
{
return new NoteOnEvent(NoteNumber, Velocity) { Channel = Channel };
}

internal NoteOffEvent GetNoteOffEvent()
public NoteOffEvent GetNoteOffEvent()
{
return new NoteOffEvent(NoteNumber, OffVelocity) { Channel = Channel };
}
Expand Down
2 changes: 1 addition & 1 deletion DryWetMidi/Multimedia/Playback/PlaybackDataTracker.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

namespace Melanchall.DryWetMidi.Multimedia
{
internal sealed class PlaybackDataTracker
public class PlaybackDataTracker
{
#region Nested enums

Expand Down
2 changes: 1 addition & 1 deletion DryWetMidi/Multimedia/Playback/PlaybackEvent.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

namespace Melanchall.DryWetMidi.Multimedia
{
internal sealed class PlaybackEvent
public class PlaybackEvent
{
#region Constructor

Expand Down
2 changes: 1 addition & 1 deletion DryWetMidi/Multimedia/Playback/PlaybackEventMetadata/NotePlaybackEventMetadata.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

namespace Melanchall.DryWetMidi.Multimedia
{
internal sealed class NotePlaybackEventMetadata
public class NotePlaybackEventMetadata
{
#region Constructor

Expand Down
2 changes: 1 addition & 1 deletion DryWetMidi/Multimedia/Playback/PlaybackEventMetadata/PlaybackEventMetadata.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
namespace Melanchall.DryWetMidi.Multimedia
{
internal sealed class PlaybackEventMetadata
public class PlaybackEventMetadata
{
public NotePlaybackEventMetadata Note { get; set; }

Expand Down
2 changes: 1 addition & 1 deletion DryWetMidi/Multimedia/Playback/PlaybackEventMetadata/TimedEventPlaybackEventMetadata.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
namespace Melanchall.DryWetMidi.Multimedia
{
internal sealed class TimedEventPlaybackEventMetadata
public class TimedEventPlaybackEventMetadata
{
#region Constructor

Expand Down
2 changes: 1 addition & 1 deletion DryWetMidi/Multimedia/Playback/PlaybackEventsComparer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

namespace Melanchall.DryWetMidi.Multimedia
{
internal sealed class PlaybackEventsComparer : IComparer<PlaybackEvent>
public class PlaybackEventsComparer : IComparer<PlaybackEvent>
{
#region IComparer<PlaybackEvent>

Expand Down