Expose classes and utility is DryWetMidi.Multimedia

[noonesimg]

Changed visibility of several properties, classes and methods to public
To allow for easier custom playback implementations

[melanchall]

Hi!

Thanks for the PR. Unfortunately I can't accept it right now because I don't see reasons to open all those classes and members.

A couple of examples:

public TimedEvent TimedNoteOnEvent
public TimedEvent TimedNoteOffEvent

Why? There are methods GetTimedNoteOnEvent and GetTimedNoteOffEvent. This is a protection from changing a note in an unexpected way.

public static IEnumerable<TimedObjectAt<ITimedObject>> GetNotesAndTimedEventsLazy

Please read Getting objects article to learn how to get objects of different types.

About Playback: without examples of usage I can't understand why you need to make those classes and members public.

I as the developer of the library must always think about common cases and API clarity. Making classes public without obvious profit just adds noise to API, set of different classes become bigger and user can be confused.

[noonesimg]

Okay, these two are definitely a mistake

public TimedEvent TimedNoteOnEvent
public TimedEvent TimedNoteOffEvent

I didn't realize those get methods exist.

Speaking of GetNotesAndTimedEventsLazy
As far as I understand, there's now other easy way to get a nice collection of PlaybackEvents without rewriting a lot of code, that's already there :)

this is from Playback.cs

var noteDetectionSettings = playbackSettings.NoteDetectionSettings ?? new NoteDetectionSettings();
_playbackEvents = GetPlaybackEvents(timedObjects.GetNotesAndTimedEventsLazy(noteDetectionSettings, true), tempoMap);
MoveToNextPlaybackEvent();

Speaking of PlaybackEvents, those have a really useful PlaybackEventsComparer which is also internal and sealed.
I was just trying to be as close to the source Playback class as possible.