Use reqwest by default #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irevoire
added
the
breaking-change
irevoire
force-pushed
the
use-reqwest-by-default
branch
from
426c152
to
7c7dd4a
Compare
|
It is as if #524 doesn't exist |
|
I did look at it, but since I didn’t have much time to work on this, I preferred to rush something that works with the community. Sorry. Once this is merged I would love to work with you on improving the SDK even more, thanks for your work |
irevoire
force-pushed
the
use-reqwest-by-default
branch
from
e09f022
to
8867b9e
Compare
irevoire
force-pushed
the
use-reqwest-by-default
branch
from
8867b9e
to
394dff2
Compare
…tomization of http client
irevoire
force-pushed
the
use-reqwest-by-default
branch
2 times, most recently
from
3d82ce6
to
060d990
Compare
irevoire
force-pushed
the
use-reqwest-by-default
branch
from
060d990
to
741bf4e
Compare
irevoire
force-pushed
the
use-reqwest-by-default
branch
from
9a4ee80
to
352f846
Compare
meili-bors bot
added a commit
that referenced
this pull request
Apr 15, 2024
563: Use reqwest by default r=irevoire a=irevoire # Pull Request ## Related issue Fixes #530 because we won’t depend on curl anymore ## What does this PR do? - Get rid of `isahc` by default in favor of `reqwest`, which is way more used in the ecosystem ## PR checklist Please check if your PR fulfills the following requirements: - [x] Create an example changing the default HTTP client - [x] Simplify the `HttpClient` trait to only require one method to be implemented - [x] Stores a basic `reqwest::Client` in the `meilisearch_sdk::Client` instead of re-creating it from scratch for every request - [x] Double check it works with wasm - [x] Remove all the unwraps in `request` - [x] Do not use the `User-Agent` when in wasm as it is often blocked by the browser Co-authored-by: Tamo <[email protected]>
|
This PR was included in a batch that successfully built, but then failed to merge into main. It will not be retried. Additional information: {"message":"At least 1 approving review is required by reviewers with write access.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
curquiza
approved these changes
Apr 15, 2024
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #530 because we won’t depend on curl anymore
What does this PR do?
isahcby default in favor ofreqwest, which is way more used in the ecosystemPR checklist
Please check if your PR fulfills the following requirements:
HttpClienttrait to only require one method to be implementedreqwest::Clientin themeilisearch_sdk::Clientinstead of re-creating it from scratch for every requestrequestUser-Agentwhen in wasm as it is often blocked by the browser