Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose isach/rustls-tls feature #547

Closed
wants to merge 1 commit into from

Conversation

maxcountryman
Copy link

This makes it possible to use rustls via the upstream feature flag.

See: https://github.com/sagebind/isahc/blob/096aff7b13f4ff5bb474fdc27bc30b297a2968f6/Cargo.toml#L29

@hazelmeow
Copy link

hazelmeow commented Feb 24, 2024

There's a typo in the name of the feature. Also, it seems like the rustls-tls feature flag in Isahc is planned for 2.0 which isn't actually released yet.

@@ -41,6 +41,7 @@ wasm-bindgen-futures = "0.4"
default = ["isahc-static-curl"]
isahc-static-curl = ["isahc/static-curl"]
isahc-static-ssl = ["isahc/static-ssl"]
isach-rustls-tls = ["isahc/rustls-tls"]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
isach-rustls-tls = ["isahc/rustls-tls"]
isahc-rustls-tls = ["isahc/rustls-tls"]

@irevoire
Copy link
Member

Closing since #563 has been merged

@irevoire irevoire closed this Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants