Support text-separator customization

[ellnix]

Pull Request

Related issue

Fixes #487

PR checklist

Please check if your PR fulfills the following requirements:

• Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
• Have you read the contributing guidelines?
• Have you made sure that the title is accurate and descriptive of the changes?

There are linter errors on both this pull request and the #491 since they add new settings, but they cannot reasonably be tackled while adding settings. A separate issue and PR would be more appropriate.

[brunoocasali]

Just a small change regarding the aliases and we're good to go!

[ellnix]

Fixed conflicts and removed setter aliases along with getters as per similar request to #491.

[brunoocasali]

bors merge

[codecov]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (c73ad5e) 99.61% compared to head (fe533a4) 99.62%.

❗ Current head fe533a4 differs from pull request most recent head c8f6fe5. Consider uploading reports for the commit c8f6fe5 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #493      +/-   ##
==========================================
+ Coverage   99.61%   99.62%   +0.01%     
==========================================
  Files           9        9              
  Lines         516      530      +14     
==========================================
+ Hits          514      528      +14     
  Misses          2        2              

Files	Coverage Δ
lib/meilisearch/index.rb	100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[brunoocasali]

@ellnix can you re ran the rubocop todo list?

[meili-bors]

Build failed:

• linter-check

[ellnix]

@ellnix can you re ran the rubocop todo list?

All of the PRs that involve adding things to the Index class have linter errors related to the size of the Index class. I also mentioned this when I first submitted the PR:

There are linter errors on both this pull request and the #491 since they add new settings, but they cannot reasonably be tackled while adding settings. A separate issue and PR would be more appropriate.

How should I proceed?

[brunoocasali]

@ellnix can you re ran the rubocop todo list?

All of the PRs that involve adding things to the Index class have linter errors related to the size of the Index class. I also mentioned this when I first submitted the PR:

There are linter errors on both this pull request and the #491 since they add new settings, but they cannot reasonably be tackled while adding settings. A separate issue and PR would be more appropriate.

How should I proceed?

I think we are good to go with just the rubocop todo thing, after that we can plan a bigger refactor in a new PR :)

[ellnix]

@brunoocasali all rebased with conflicts and rubocop fixed.

[brunoocasali]

bors merge

Thanks a lot @ellnix you rocks!

[meili-bors]

Build failed:

• integration-tests (ruby 2.6)

[brunoocasali]

bors merge

[meili-bors]

Build succeeded:

• integration-tests (ruby 2.6)
• integration-tests (ruby 2.7)
• integration-tests (ruby 3.0)
• linter-check