Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.4] Support text-separator customization #487

Closed
10 tasks
curquiza opened this issue Sep 27, 2023 · 0 comments · Fixed by #493
Closed
10 tasks

[v1.4] Support text-separator customization #487

curquiza opened this issue Sep 27, 2023 · 0 comments · Fixed by #493
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@curquiza
Copy link
Member

Following this central issue

  • Add two new settings: separatorTokens and nonSeparatorTokens with get, update, and reset methods associated.
    Here are the JS equivalents in meilisearch-js you should create for this repository:
client.index('indexName').getSeparatorTokens(); // calls GET /indexes/:uid/settings/separator-tokens
client.index('indexName').updateSeparatorTokens(['|', '/', '&sep']);  // calls PUT /indexes/:uid/settings/separator-tokens
client.index('indexName').resetSeparatorTokens(); // calls DELETE /indexes/:uid/settings/separator-tokens

client.index('indexName').getNonSeparatorTokens(); // calls GET /indexes/:uid/settings/non-separator-tokens
client.index('indexName').updateNonSeparatorTokens(['@', '#']); // calls PUT /indexes/:uid/settings/non-separator-tokens
client.index('indexName').resetNonSeparatorTokens(); // calls DELETE /indexes/:uid/settings/non-separator-tokens
@curquiza curquiza added enhancement New feature or request good first issue Good for newcomers labels Sep 27, 2023
meili-bors bot added a commit that referenced this issue Oct 9, 2023
493: Support text-separator customization r=brunoocasali a=ellnix

# Pull Request

## Related issue
Fixes #487 

## PR checklist
Please check if your PR fulfills the following requirements:
- [X] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [X] Have you read the contributing guidelines?
- [X] Have you made sure that the title is accurate and descriptive of the changes?

There are linter errors on both this pull request and the #491 since they add new settings, but they cannot reasonably be tackled while adding settings. A separate issue and PR would be more appropriate.

Co-authored-by: ellnix <[email protected]>
Co-authored-by: Bruno Casali <[email protected]>
meili-bors bot added a commit that referenced this issue Oct 10, 2023
493: Support text-separator customization r=brunoocasali a=ellnix

# Pull Request

## Related issue
Fixes #487 

## PR checklist
Please check if your PR fulfills the following requirements:
- [X] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [X] Have you read the contributing guidelines?
- [X] Have you made sure that the title is accurate and descriptive of the changes?

There are linter errors on both this pull request and the #491 since they add new settings, but they cannot reasonably be tackled while adding settings. A separate issue and PR would be more appropriate.

Co-authored-by: ellnix <[email protected]>
Co-authored-by: Bruno Casali <[email protected]>
@meili-bors meili-bors bot closed this as completed in fb6bbc0 Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant