Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change create_index prototype #39

Merged
merged 1 commit into from
Jun 12, 2020
Merged

Change create_index prototype #39

merged 1 commit into from
Jun 12, 2020

Conversation

curquiza
Copy link
Member

@curquiza curquiza commented Jun 10, 2020 •
edited
Loading

Related to this comment.

Before:

$client->createIndex('indexUID')
$client->createIndex(['uid' => 'indexUID', 'primaryKey' => 'book_id'])

After:

$client->createIndex('indexUID')
$client->createIndex('indexUID', ['primaryKey' => 'book_id'])

@curquiza curquiza requested a review from eskombro June 10, 2020 16:50
@curquiza curquiza mentioned this pull request Jun 10, 2020
Merged
eskombro
eskombro approved these changes Jun 11, 2020
View reviewed changes
Copy link
Member

@eskombro eskombro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! 🎉

@curquiza curquiza merged commit aeab06a into bump-meilisearch-v0.11 Jun 12, 2020
@curquiza curquiza deleted the change-create-index-method branch June 12, 2020 07:33
curquiza added a commit that referenced this pull request Jun 15, 2020
@curquiza
Upd package for MeiliSearch v0.11 (#35)
81b67c8 
* Upd version

* Add method to use faceting sub routes (#36)

* Implement faceting in search (#37)

* Change create_index prototype (#39)

* Add test with multiple facetFilters (#38)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eskombro eskombro eskombro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@curquiza @eskombro